streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smashew <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 86
Date Mon, 19 May 2014 19:43:01 GMT
Github user smashew commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/17#discussion_r12812370
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java
---
    @@ -54,12 +72,14 @@ public void setConfig(TwitterStreamConfiguration config) {
             this.config = config;
         }
     
    -    protected final Queue<StreamsDatum> providerQueue = Queues.synchronizedQueue(new
ArrayBlockingQueue<StreamsDatum>(5000));
    +    protected volatile Queue<StreamsDatum> providerQueue;
     
         protected int idsCount;
         protected Twitter client;
    --- End diff --
    
    in your method below, it is being treated as an instance variable. with only one function
really needing to access it. Refactoring out the private just keeps memory issues to a min.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message