streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smashew <>
Subject [GitHub] incubator-streams pull request: Streams 86
Date Mon, 19 May 2014 19:41:06 GMT
Github user smashew commented on a diff in the pull request:
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/
    @@ -45,6 +62,7 @@
         private TwitterStreamConfiguration config;
         private Class klass;
    +    private ReadWriteLock lock = new ReentrantReadWriteLock();
    --- End diff --
    might as well make this final so you don't accidentally overwrite the lock during execution.
Also allows for it to be farmed out to other threads if necessary. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message