streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smashew <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Changes necessary to satisfy JIRA ...
Date Mon, 12 May 2014 17:56:35 GMT
Github user smashew commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/13#discussion_r12543630
  
    --- Diff: streams-contrib/streams-processor-urls/src/main/java/org/apache/streams/urls/LinkResolver.java
---
    @@ -14,31 +14,43 @@
     import java.net.URLDecoder;
     import java.util.*;
     
    -/**
    - * References:
    - * Some helpful references to help
    - * Purpose              URL
    - * -------------        ----------------------------------------------------------------
    - * [Status Codes]       http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
    - * [Test Cases]         http://greenbytes.de/tech/tc/httpredirects/
    - * [t.co behavior]      https://dev.twitter.com/docs/tco-redirection-behavior
    - */
    -
    -public class LinkResolver implements Serializable
    -{
    +public class LinkResolver implements Serializable {
    +
    +    /**
    --- End diff --
    
    I don't know that it is JavaDoc worthy. More helpful to the developer of the class and
it's internals. It helps to explain the nuances of redirects as it relates to different domains.
Something that the caller shouldn't need to be aware of from a 'doc' perspective.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message