streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Twitter Modificaitons
Date Tue, 06 May 2014 13:18:02 GMT
Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/8#discussion_r12323298
  
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StatusCounterMonitorRunnable.java
---
    @@ -0,0 +1,6 @@
    +package org.apache.streams.local.tasks;
    +
    +public interface StatusCounterMonitorRunnable extends Runnable {
    --- End diff --
    
    Completely agree on the use of the interface.  I was just wondering why it is StatusCounterMonitorRunnable
when its methods are shutdown and isRunning.  It would make sense to me to call it StoppableRunnable
or something like that; but, I may be misunderstanding the use case and the Java Doc on the
interface doesn't clarify it for me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message