streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smashew <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Twitter Modificaitons
Date Mon, 05 May 2014 22:49:36 GMT
Github user smashew commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/8#discussion_r12304068
  
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StatusCounterMonitorRunnable.java
---
    @@ -0,0 +1,6 @@
    +package org.apache.streams.local.tasks;
    +
    +public interface StatusCounterMonitorRunnable extends Runnable {
    --- End diff --
    
    There is heavy code duplication in the LocalStreamBuilders that should re-factored to
an interface, I'm not picky on the name, but, seeing as the behaviors are consistent and consistently
applied, it is JBPs to use an interface to more accurately describe the behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message