streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Twitter Modificaitons
Date Mon, 05 May 2014 21:33:00 GMT
Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/8#discussion_r12301019
  
    --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3ObjectInputStreamWrapper.java
---
    @@ -0,0 +1,111 @@
    +package org.apache.streams.s3;
    +
    +import com.amazonaws.services.s3.model.S3Object;
    +import com.amazonaws.services.s3.model.S3ObjectInputStream;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.Closeable;
    +import java.io.IOException;
    +import java.io.InputStream;
    +
    +import com.amazonaws.services.s3.model.S3Object;
    +import com.amazonaws.services.s3.model.S3ObjectInputStream;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.Closeable;
    +import java.io.IOException;
    +import java.io.InputStream;
    +
    +/**
    + * There is a stupid nuance associated with reading portions of files in S3. Everything
occurs over
    --- End diff --
    
    Keep in mind these comments will be published as Java docs.  We generally don't include
author information either.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message