streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smashew <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Twitter Modificaitons
Date Mon, 05 May 2014 20:52:39 GMT
Github user smashew commented on the pull request:

    https://github.com/apache/incubator-streams/pull/8#issuecomment-42237930
  
    To play devil's advocate, by that logic, one could just have one single configuration
for everything in streams and an enum that could delegate the parameters where necessary.
I simply, and made back-wards compatible, a configuration that is tailored to each end-point
that one could pull from Twitter. This allows for clarity of usage by the caller and ensures
erroneous parameters aren't possible to be constructed which would be implicitly ignored by
the the operation. 
    
    IE: Tracking a stream for keyword, would be different than tracking individuals by ID.
This is reflected in Twitter's API documentation. To mirror these parameters ensures the caller
can use the module without having to have explicit knowledge of the inner workings of the
provider. 
    
    I hope that this isn't too far reaching, but code clarity seems of upmost importance to
ensure proper adoption by a wider community.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message