Return-Path: X-Original-To: apmail-streams-dev-archive@minotaur.apache.org Delivered-To: apmail-streams-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 19C1511E0A for ; Fri, 21 Feb 2014 20:05:30 +0000 (UTC) Received: (qmail 77976 invoked by uid 500); 21 Feb 2014 20:05:28 -0000 Delivered-To: apmail-streams-dev-archive@streams.apache.org Received: (qmail 77930 invoked by uid 500); 21 Feb 2014 20:05:27 -0000 Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@streams.incubator.apache.org Delivered-To: mailing list dev@streams.incubator.apache.org Received: (qmail 77880 invoked by uid 99); 21 Feb 2014 20:05:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Feb 2014 20:05:26 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 21 Feb 2014 20:05:24 +0000 Received: (qmail 77477 invoked by uid 99); 21 Feb 2014 20:05:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Feb 2014 20:05:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6D2691D492C; Fri, 21 Feb 2014 20:05:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6617807599836322746==" MIME-Version: 1.0 Subject: Review Request 18369: Issue STREAMS-26 in JIRA From: "Ryan Ebanks" To: "streams" , "Ryan Ebanks" Date: Fri, 21 Feb 2014 20:05:03 -0000 Message-ID: <20140221200503.29785.29263@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ryan Ebanks" X-ReviewGroup: streams X-ReviewRequest-URL: https://reviews.apache.org/r/18369/ X-Sender: "Ryan Ebanks" Reply-To: "Ryan Ebanks" X-ReviewRequest-Repository: streams X-Virus-Checked: Checked by ClamAV on apache.org --===============6617807599836322746== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18369/ ----------------------------------------------------------- Review request for streams. Repository: streams Description ------- I made changes to simplify the interfaces for StreamsPersistWriter, StreamsProcessor, and StreamsProvider. The reasons for the changes was to create a simple framework for running an activity stream in a single JVM, and to create a class that allowed a user to easily declare, and run their stream in a few lines of of code. The interfaces have only slightly changed, mainly its the removal of certain methods. The new changes, I believe this will allow for easy mapping of activity streams to other projects frame work, such as Storm, Hadoop, etc. The builder interface used for declare and launching the stream will be easily extended to Storm. When the patch gets approved I will work on implementing that. Diffs ----- trunk/streams-core/pom.xml 1570675 trunk/streams-core/src/main/java/org/apache/streams/core/StreamsDatum.java 1570675 trunk/streams-core/src/main/java/org/apache/streams/core/StreamsOperation.java PRE-CREATION trunk/streams-core/src/main/java/org/apache/streams/core/StreamsPersistReader.java 1570675 trunk/streams-core/src/main/java/org/apache/streams/core/StreamsPersistWriter.java 1570675 trunk/streams-core/src/main/java/org/apache/streams/core/StreamsProcessor.java 1570675 trunk/streams-core/src/main/java/org/apache/streams/core/StreamsProvider.java 1570675 trunk/streams-core/src/main/java/org/apache/streams/core/builders/InvalidStreamException.java PRE-CREATION trunk/streams-core/src/main/java/org/apache/streams/core/builders/LocalStreamBuilder.java PRE-CREATION trunk/streams-core/src/main/java/org/apache/streams/core/builders/StreamBuilder.java PRE-CREATION trunk/streams-core/src/main/java/org/apache/streams/core/builders/StreamComponent.java PRE-CREATION trunk/streams-core/src/main/java/org/apache/streams/core/tasks/BaseStreamsTask.java PRE-CREATION trunk/streams-core/src/main/java/org/apache/streams/core/tasks/StreamsMergeTask.java PRE-CREATION trunk/streams-core/src/main/java/org/apache/streams/core/tasks/StreamsPersistWriterTask.java PRE-CREATION trunk/streams-core/src/main/java/org/apache/streams/core/tasks/StreamsProcessorTask.java PRE-CREATION trunk/streams-core/src/main/java/org/apache/streams/core/tasks/StreamsProviderTask.java PRE-CREATION trunk/streams-core/src/main/java/org/apache/streams/core/tasks/StreamsTask.java PRE-CREATION trunk/streams-core/src/test/java/org/apache/streams/core/builders/LocalStreamBuilderTest.java PRE-CREATION trunk/streams-core/src/test/java/org/apache/streams/core/builders/ToyLocalBuilderExample.java PRE-CREATION trunk/streams-core/src/test/java/org/apache/streams/core/tasks/BasicTasksTest.java PRE-CREATION trunk/streams-core/src/test/java/org/apache/streams/core/test/processors/DoNothingProcessor.java PRE-CREATION trunk/streams-core/src/test/java/org/apache/streams/core/test/processors/PassthroughDatumCounterProcessor.java PRE-CREATION trunk/streams-core/src/test/java/org/apache/streams/core/test/providers/NumericMessageProvider.java PRE-CREATION trunk/streams-core/src/test/java/org/apache/streams/core/test/writer/DatumCounterWriter.java PRE-CREATION trunk/streams-core/src/test/java/org/apache/streams/core/test/writer/DoNothingWriter.java PRE-CREATION trunk/streams-core/src/test/java/org/apache/streams/core/test/writer/SystemOutWriter.java PRE-CREATION trunk/streams-util/src/main/java/org/apache/streams/util/SerializationUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/18369/diff/ Testing ------- There are units for the new functionality and classes. I admit they are a little 'hacky'. Thanks, Ryan Ebanks --===============6617807599836322746==--