Return-Path: X-Original-To: apmail-streams-dev-archive@minotaur.apache.org Delivered-To: apmail-streams-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2344610D59 for ; Mon, 15 Jul 2013 13:32:57 +0000 (UTC) Received: (qmail 67587 invoked by uid 500); 15 Jul 2013 13:32:53 -0000 Delivered-To: apmail-streams-dev-archive@streams.apache.org Received: (qmail 67461 invoked by uid 500); 15 Jul 2013 13:32:46 -0000 Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@streams.incubator.apache.org Delivered-To: mailing list dev@streams.incubator.apache.org Received: (qmail 67440 invoked by uid 99); 15 Jul 2013 13:32:43 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jul 2013 13:32:43 +0000 X-ASF-Spam-Status: No, hits=2.4 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of dsullivan7@hotmail.com designates 65.55.90.177 as permitted sender) Received: from [65.55.90.177] (HELO snt0-omc3-s38.snt0.hotmail.com) (65.55.90.177) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jul 2013 13:32:31 +0000 Received: from SNT130-W18 ([65.55.90.135]) by snt0-omc3-s38.snt0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 15 Jul 2013 06:32:11 -0700 X-TMN: [3EI29GDoxdRkgZRt2GR7s5l2537QF0ln] X-Originating-Email: [dsullivan7@hotmail.com] Message-ID: Content-Type: multipart/alternative; boundary="_6ae0348a-a62e-4590-81fc-cfb851f6df6e_" From: Danny Sullivan To: streams Subject: RE: Review Request 12336: Adding Model Object and Translating From and To JSON Date: Mon, 15 Jul 2013 09:32:09 -0400 Importance: Normal In-Reply-To: <20130708194443.14335.29840@reviews.apache.org> References: <20130708194443.14335.29840@reviews.apache.org> MIME-Version: 1.0 X-OriginalArrivalTime: 15 Jul 2013 13:32:11.0075 (UTC) FILETIME=[B5B53130:01CE815F] X-Virus-Checked: Checked by ClamAV on apache.org --_6ae0348a-a62e-4590-81fc-cfb851f6df6e_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Is someone code reviewing this? > Subject: Review Request 12336: Adding Model Object and Translating From a= nd To JSON > From: dsullivan7@hotmail.com > To: dev@streams.incubator.apache.org=3B dsullivan7@hotmail.com > Date: Mon=2C 8 Jul 2013 19:44:43 +0000 >=20 >=20 > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply=2C visit: > https://reviews.apache.org/r/12336/ > ----------------------------------------------------------- >=20 > Review request for streams. >=20 >=20 > Repository: streams >=20 >=20 > Description > ------- >=20 > Adding serializable model class for activity object. The SerivalizableAct= ivityStreamsEntry class is bassed on the ActivityStreamsEntryImpl class in = Rave. The reason I didn't extend the ActivityStreamsEntryImpl class was I w= as having trouble translating the fields from JSON. The serialized object i= s created from the JSON passed in from the publisher.=20 >=20 >=20 > Diffs > ----- >=20 > trunk/streams-eip-routes/pom.xml 1500880=20 > trunk/streams-eip-routes/src/main/java/org/apache/streams/messaging/agg= regation/ActivityAggregator.java 1500880=20 > trunk/streams-osgi-components/activity-consumer/pom.xml 1500880=20 > trunk/streams-osgi-components/activity-consumer/src/main/java/org/apach= e/streams/osgi/components/activityconsumer/impl/PushActivityConsumer.java 1= 500880=20 > trunk/streams-osgi-components/activity-consumer/src/main/java/org/apach= e/streams/osgi/components/activityconsumer/impl/SerializableActivityStreams= Entry.java PRE-CREATION=20 >=20 > Diff: https://reviews.apache.org/r/12336/diff/ >=20 >=20 > Testing > ------- >=20 >=20 > Thanks=2C >=20 > Daniel Sullivan >=20 = --_6ae0348a-a62e-4590-81fc-cfb851f6df6e_--