Return-Path: X-Original-To: apmail-streams-dev-archive@minotaur.apache.org Delivered-To: apmail-streams-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2656810F10 for ; Mon, 15 Jul 2013 14:20:40 +0000 (UTC) Received: (qmail 65512 invoked by uid 500); 15 Jul 2013 14:20:40 -0000 Delivered-To: apmail-streams-dev-archive@streams.apache.org Received: (qmail 65465 invoked by uid 500); 15 Jul 2013 14:20:39 -0000 Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@streams.incubator.apache.org Delivered-To: mailing list dev@streams.incubator.apache.org Received: (qmail 65450 invoked by uid 99); 15 Jul 2013 14:20:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jul 2013 14:20:38 +0000 X-ASF-Spam-Status: No, hits=-1996.8 required=5.0 tests=ALL_TRUSTED,FORGED_HOTMAIL_RCVD2,FREEMAIL_REPLYTO_END_DIGIT,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 15 Jul 2013 14:20:37 +0000 Received: (qmail 65051 invoked by uid 99); 15 Jul 2013 14:20:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jul 2013 14:20:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A2BFE1CF2B4; Mon, 15 Jul 2013 14:20:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2939614864159645935==" MIME-Version: 1.0 Subject: Re: Review Request 12336: Adding Model Object and Translating From and To JSON From: "Daniel Sullivan" To: "streams" , "Daniel Sullivan" Date: Mon, 15 Jul 2013 14:20:07 -0000 Message-ID: <20130715142007.28534.90999@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Daniel Sullivan" X-ReviewGroup: streams X-ReviewRequest-URL: https://reviews.apache.org/r/12336/ X-Sender: "Daniel Sullivan" References: <20130708194443.14335.29840@reviews.apache.org> In-Reply-To: <20130708194443.14335.29840@reviews.apache.org> Reply-To: "Daniel Sullivan" X-Virus-Checked: Checked by ClamAV on apache.org --===============2939614864159645935== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12336/#review23154 ----------------------------------------------------------- Ship it! Ship It! - Daniel Sullivan On July 8, 2013, 7:44 p.m., Daniel Sullivan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12336/ > ----------------------------------------------------------- > > (Updated July 8, 2013, 7:44 p.m.) > > > Review request for streams. > > > Repository: streams > > > Description > ------- > > Adding serializable model class for activity object. The SerivalizableActivityStreamsEntry class is bassed on the ActivityStreamsEntryImpl class in Rave. The reason I didn't extend the ActivityStreamsEntryImpl class was I was having trouble translating the fields from JSON. The serialized object is created from the JSON passed in from the publisher. > > > Diffs > ----- > > trunk/streams-eip-routes/pom.xml 1500880 > trunk/streams-eip-routes/src/main/java/org/apache/streams/messaging/aggregation/ActivityAggregator.java 1500880 > trunk/streams-osgi-components/activity-consumer/pom.xml 1500880 > trunk/streams-osgi-components/activity-consumer/src/main/java/org/apache/streams/osgi/components/activityconsumer/impl/PushActivityConsumer.java 1500880 > trunk/streams-osgi-components/activity-consumer/src/main/java/org/apache/streams/osgi/components/activityconsumer/impl/SerializableActivityStreamsEntry.java PRE-CREATION > > Diff: https://reviews.apache.org/r/12336/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Sullivan > > --===============2939614864159645935==--