streams-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-496) Remove twitter4j dependency from streams-provider-twitter
Date Thu, 13 Apr 2017 02:00:46 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966996#comment-15966996
] 

ASF GitHub Bot commented on STREAMS-496:
----------------------------------------

Github user jfrazee commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/360#discussion_r111297739
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Followers.java
---
    @@ -0,0 +1,52 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.streams.twitter.api;
    +
    +import org.apache.streams.twitter.pojo.Tweet;
    +
    +import java.util.List;
    +
    +/**
    + * Returns a collection of the most recent Tweets posted by the user indicated by the
screen_name or user_id parameters.
    --- End diff --
    
    I think this is the wrong javadoc for this interface. Should probably say something about
the follower IDs and user objects, right?


> Remove twitter4j dependency from streams-provider-twitter
> ---------------------------------------------------------
>
>                 Key: STREAMS-496
>                 URL: https://issues.apache.org/jira/browse/STREAMS-496
>             Project: Streams
>          Issue Type: Task
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>             Fix For: 0.5.1
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Per discussion on legal@ releases that include modules with the json license are not
permitted after April 30, 2017.
> twitter4j has such a dependency and has shown little willingness to address it.
> Switch off twitter4j to HTTP API interaction.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message