streampipes-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Wiener (Jira)" <j...@apache.org>
Subject [jira] [Updated] (STREAMPIPES-100) Remove iconUrl option from pipeline element builder
Date Sun, 01 Mar 2020 13:53:00 GMT

     [ https://issues.apache.org/jira/browse/STREAMPIPES-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Patrick Wiener updated STREAMPIPES-100:
---------------------------------------
    Description: Pipeline elements should use *.withAssets()* to propagate PE icons. So *.iconUrl()*
is not needed anymore (for PE). Especially in the case of the pipeline elements all JVM container,
this causes the unexpected behaviour of registering the corresponding PE algorithms in Consul,
since *.iconUrl()* calls the correspondig config, which in turn registers itself.  (was: Pipeline
elements should use *.withAssets()* to propagate PE icons. So *.iconUrl()* is not needed anymore.
Especially in the case of the pipeline elements all JVM container, this causes the unexpected
behaviour of registering the corresponding PE algorithms in Consul, since *.iconUrl()* calls
the correspondig config, which in turn registers itself.

We should mark iconUrl() as deprecated and remove the method call from the PE config.
{code:java}
@Deprecated
/**
 * @deprecated: Use {@link #withAssets(String...)} instead
 */
public BU iconUrl(String iconUrl) {
  elementDescription.setIconUrl(iconUrl);
  return me();
}
{code})

> Remove iconUrl option from pipeline element builder
> ---------------------------------------------------
>
>                 Key: STREAMPIPES-100
>                 URL: https://issues.apache.org/jira/browse/STREAMPIPES-100
>             Project: StreamPipes
>          Issue Type: Bug
>            Reporter: Patrick Wiener
>            Priority: Major
>
> Pipeline elements should use *.withAssets()* to propagate PE icons. So *.iconUrl()* is
not needed anymore (for PE). Especially in the case of the pipeline elements all JVM container,
this causes the unexpected behaviour of registering the corresponding PE algorithms in Consul,
since *.iconUrl()* calls the correspondig config, which in turn registers itself.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message