stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Imesh Gunaratne <im...@apache.org>
Subject Re: Stratos master branch is unstable
Date Tue, 28 Jun 2016 08:57:00 GMT
On Fri, Jun 17, 2016 at 4:15 PM, Akila Ravihansa Perera <
ravihansa3000@gmail.com> wrote:

> Hi,
>
> This issue is now fixed in master branch now. All integration tests are
> now enabled during build time. Stratos master commit build passed
> successfully [1]. Following are the changes made;
>
>  - Replaced Axis services wsdl files for AS, SM, CC components from
> generated resources (via java2wsdl plugin)
>  - Changed methods having return type of "void" to "boolean" as a
> workaround for [2]. Still not sure why this popped up suddenly. Perhaps it
> never worked and we didn't know because integration tests were not running
>  - Fix obsolete expiry timeout calculation logic [3]
>  - Enabled all integration tests at build time (removed group inclusion
> statement in TestNG configuration)
>

Great work Akila!

>
> [1]
> https://builds.apache.org/view/All/job/Stratos-Master-Commit-Build/839/
> [2] https://issues.apache.org/jira/browse/AXIS2-4408
> [3] https://issues.apache.org/jira/browse/STRATOS-1660
>
> Thanks.
>
>
> On Fri, Jun 17, 2016 at 10:56 AM, Isuru Haththotuwa <isuruh@apache.org>
> wrote:
>
>> Hi Akila,
>>
>> On Thu, Jun 16, 2016 at 9:31 PM, Akila Ravihansa Perera <
>> ravihansa@apache.org> wrote:
>>
>>> Hi,
>>>
>>> It seems integration tests have not been running due to a change made in
>>> [1] since 2015 Dec 8. Only tests under "policies" group have been running
>>> since then. When I enabled all integration test (by removing group
>>> inclusion in [1]), 11 test cases failed due to following error, which is
>>> already reported in [2].
>>>
>>> Caused by: org.apache.axis2.AxisFault: The input stream for an incoming
>>> message is null.
>>>
>>> Basically, what this means is that Stratos on master branch is
>>> completely unusable.
>>>
>>> Devs, please pay attention when you update test cases or test suite
>>> configuration. We could have detected this issue at a very early stage if
>>> those test cases have been running.
>>>
>> Fully agreed.
>>
>>>
>>> It looks like this has occurred due to void type methods in Axis2
>>> services which seems to be a known issue [3]. But I'm not sure why this
>>> suddenly popped up. I've added "boolean" return type as a temporary
>>> workaround to resolve this. I've successfully verified this in a local
>>> setup.
>>>
>> AFAIK we need to merge the stratos-4.1.x branch to master. AFAIR there
>> are some changes that were specifically committed to this branch, and it
>> was in a stable state. After its merged, lets perform a full build and see
>> if there are any integrations tests failing.
>>
>> [1]
>> https://github.com/apache/stratos/commit/9d778a5edd3855162eff971ce684659ef72673e0#diff-e84f3dd5d5f4984e39423efaf6d5dd9eR37
>>
>> [2] https://issues.apache.org/jira/browse/STRATOS-1647
>>
>> [3] https://issues.apache.org/jira/browse/AXIS2-4408
>>
>> Thanks.
>>
>> --
>> Thanks and Regards,
>>
>> Isuru H.
>> +94 716 358 048* <http://wso2.com/>*
>>
>>
>> * <http://wso2.com/>*
>>
>>
>>
>


-- 
Imesh Gunaratne

Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos

Mime
View raw message