Return-Path: 
 <dev-return-26504-apmail-stratos-dev-archive=stratos.apache.org@stratos.apache.org>
X-Original-To: apmail-stratos-dev-archive@minotaur.apache.org
Delivered-To: apmail-stratos-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 310CA18F69
	for <apmail-stratos-dev-archive@minotaur.apache.org>;
 Mon, 30 Nov 2015 05:39:21 +0000 (UTC)
Received: (qmail 59930 invoked by uid 500); 30 Nov 2015 05:39:21 -0000
Delivered-To: apmail-stratos-dev-archive@stratos.apache.org
Received: (qmail 59876 invoked by uid 500); 30 Nov 2015 05:39:21 -0000
Mailing-List: contact dev-help@stratos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@stratos.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@stratos.apache.org>
List-Post: <mailto:dev@stratos.apache.org>
List-Id: <dev.stratos.apache.org>
Reply-To: dev@stratos.apache.org
Delivered-To: mailing list dev@stratos.apache.org
Received: (qmail 59866 invoked by uid 99); 30 Nov 2015 05:39:21 -0000
Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Nov 2015 05:39:21 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org)
 with ESMTP id 6FF75C7F1D
	for <dev@stratos.apache.org>; Mon, 30 Nov 2015 05:39:20 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 1.791
X-Spam-Level: *
X-Spam-Status: No, score=1.791 tagged_above=-999 required=6.31
	tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1,
	T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled
Received: from mx1-eu-west.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new,
 port 10024)
	with ESMTP id Lxo8WWEqEkRM for <dev@stratos.apache.org>;
	Mon, 30 Nov 2015 05:39:12 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with
 SMTP id DA61320BF1
	for <dev@stratos.incubator.apache.org>; Mon, 30 Nov 2015 05:39:11 +0000 (UTC)
Received: (qmail 59119 invoked by uid 99); 30 Nov 2015 05:39:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Nov 2015 05:39:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id EEF0A2C1F6B
	for <dev@stratos.incubator.apache.org>; Mon, 30 Nov 2015 05:39:10 +0000 (UTC)
Date: Mon, 30 Nov 2015 05:39:10 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@stratos.incubator.apache.org
Message-ID: <JIRA.12916792.1448792013000.218316.1448861950975@Atlassian.JIRA>
In-Reply-To: <JIRA.12916792.1448792013000@Atlassian.JIRA>
References: <JIRA.12916792.1448792013000@Atlassian.JIRA>
 <JIRA.12916792.1448792013320@arcas>
Subject: [jira] [Commented] (STRATOS-1632) DataPublisher objects are created
 for nodes which has statsPublisherEnabled set to false in
 thrift-client-config.xml
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/STRATOS-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031337#comment-15031337 ] 

ASF GitHub Bot commented on STRATOS-1632:
-----------------------------------------

Github user swgkg commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/496#discussion_r46110016
  
    --- Diff: components/org.apache.stratos.common/src/main/java/org/apache/stratos/common/statistics/publisher/ThriftStatisticsPublisher.java ---
    @@ -85,11 +85,13 @@ private void init() {
             ArrayList<ReceiverGroup> receiverGroups = new ArrayList<ReceiverGroup>();
     
             for (ThriftClientInfo thriftClientInfo : thriftClientInfoList) {
    -            ArrayList<DataPublisherHolder> dataPublisherHolders = new ArrayList<DataPublisherHolder>();
    -            DataPublisherHolder aNode = new DataPublisherHolder(null, buildUrl(thriftClientInfo), thriftClientInfo.getUsername(), thriftClientInfo.getPassword());
    -            dataPublisherHolders.add(aNode);
    -            ReceiverGroup group = new ReceiverGroup(dataPublisherHolders);
    -            receiverGroups.add(group);
    +            if (thriftClientInfo.isStatsPublisherEnabled()) {
    +                ArrayList<DataPublisherHolder> dataPublisherHolders = new ArrayList<DataPublisherHolder>();
    +                DataPublisherHolder aNode = new DataPublisherHolder(null, buildUrl(thriftClientInfo), thriftClientInfo.getUsername(), thriftClientInfo.getPassword());
    +                dataPublisherHolders.add(aNode);
    +                ReceiverGroup group = new ReceiverGroup(dataPublisherHolders);
    +                receiverGroups.add(group);
    +            }
             }
             return receiverGroups;
     
    --- End diff --
    
    Also it is better to have some debug logs on this flow.


> DataPublisher objects are created for nodes which has statsPublisherEnabled set to false in thrift-client-config.xml
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: STRATOS-1632
>                 URL: https://issues.apache.org/jira/browse/STRATOS-1632
>             Project: Stratos
>          Issue Type: Bug
>    Affects Versions: 4.1.4, 4.1.5
>            Reporter: Thanuja Uruththirakodeeswaran
>
>  When we have enabled stats publishing for one node and disabled for another node in thrift-client-config.xml file, Stratos is trying to publish data to both nodes. This is because when creating load balancing type data publisher, it is creating DataPublisher for ThriftClientInfo object which has false value set to statsPublisherEnabled attribute.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)