stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STRATOS-1632) DataPublisher objects are created for nodes which has statsPublisherEnabled set to false in thrift-client-config.xml
Date Mon, 30 Nov 2015 10:47:11 GMT

    [ https://issues.apache.org/jira/browse/STRATOS-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031642#comment-15031642
] 

ASF GitHub Bot commented on STRATOS-1632:
-----------------------------------------

Github user Thanu commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/496#discussion_r46128897
  
    --- Diff: components/org.apache.stratos.common/src/main/java/org/apache/stratos/common/statistics/publisher/ThriftStatisticsPublisher.java
---
    @@ -83,25 +83,28 @@ private void init() {
         private ArrayList<ReceiverGroup> getReceiverGroups() {
     
             ArrayList<ReceiverGroup> receiverGroups = new ArrayList<ReceiverGroup>();
    +        ArrayList<DataPublisherHolder> dataPublisherHolders = new ArrayList<DataPublisherHolder>();
    +        DataPublisherHolder aNode;
     
             for (ThriftClientInfo thriftClientInfo : thriftClientInfoList) {
    -            ArrayList<DataPublisherHolder> dataPublisherHolders = new ArrayList<DataPublisherHolder>();
    -            DataPublisherHolder aNode = new DataPublisherHolder(null, buildUrl(thriftClientInfo),
thriftClientInfo.getUsername(), thriftClientInfo.getPassword());
    -            dataPublisherHolders.add(aNode);
    -            ReceiverGroup group = new ReceiverGroup(dataPublisherHolders);
    -            receiverGroups.add(group);
    +            if (thriftClientInfo.isStatsPublisherEnabled()) {
    +                aNode = new DataPublisherHolder(null, buildUrl(thriftClientInfo), thriftClientInfo.getUsername(),
    --- End diff --
    
    Yes, we don't need a reference object and can add new DataPublisherHolder object to dataPublisherHolders
list. Removed it and added unit test in commit 40eabcc6dfbbc3dd35de98660d0d5a0d00330417.


> DataPublisher objects are created for nodes which has statsPublisherEnabled set to false
in thrift-client-config.xml
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: STRATOS-1632
>                 URL: https://issues.apache.org/jira/browse/STRATOS-1632
>             Project: Stratos
>          Issue Type: Bug
>    Affects Versions: 4.1.4, 4.1.5
>            Reporter: Thanuja Uruththirakodeeswaran
>
>  When we have enabled stats publishing for one node and disabled for another node in
thrift-client-config.xml file, Stratos is trying to publish data to both nodes. This is because
when creating load balancing type data publisher, it is creating DataPublisher for ThriftClientInfo
object which has false value set to statsPublisherEnabled attribute.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message