stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pubudu Gunatilaka <pubu...@wso2.com>
Subject Re: PCA live test is failing
Date Wed, 11 Nov 2015 18:17:49 GMT
Hi,

I will look into this. We may have to change [1] as well.

[1] -
https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/PythonAgentIntegrationTest.java#L130

Thank you!

On Wed, Nov 11, 2015 at 7:05 PM, Akila Ravihansa Perera <ravihansa@wso2.com>
wrote:

> Hi,
>
> Looks like PCA live test case for CEPHAModeTestCase is failing. Noticed
> few issues in this test case.
>
>  - Calling read() method in FIS does not guarantee that complete file is
> loaded [1]
>  - cepPort + 1 is confusing. Use a public const with the actual value [2]
>  - Method name should be fixed to reflect the test case [3]
>  - Always add proper logs with information needed to troubleshoot if the
> test case fails [4, 5]
>
> Shall we fix these issues please?
>
> [1]
> https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/CEPHAModeTestCase.java#L87
>
> [2]
> https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/CEPHAModeTestCase.java#L96
>
> [3]
> https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/CEPHAModeTestCase.java#L73
>
> [4]
> https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/CEPHAModeTestCase.java#L259
>
> [5]
> https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/CEPHAModeTestCase.java#L160
>
>
> Thanks.
>
> --
> Akila Ravihansa Perera
> WSO2 Inc.;  http://wso2.com/
>
> Blog: http://ravihansa3000.blogspot.com
>



-- 
*Pubudu Gunatilaka*
Committer and PMC Member - Apache Stratos
Software Engineer
WSO2, Inc.: http://wso2.com
mobile : +94774079049 <%2B94772207163>

Mime
View raw message