stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Imesh Gunaratne <im...@apache.org>
Subject Re: Improving the way integration tests check whether the server is ready handle request
Date Sat, 28 Nov 2015 18:55:28 GMT
Great work Raj!!

On Sat, Nov 28, 2015 at 11:54 PM, Rajkumar Rajaratnam <rajkumarr@wso2.com>
wrote:

> Hi Imesh,
>
> Yes, the above proposed solution is implemented, code-reviewed and
> available in 4.1.5 release.
>
> Thanks,
> Raj.
>
> On Sat, Nov 28, 2015 at 11:49 PM, Imesh Gunaratne <imesh@apache.org>
> wrote:
>
>> Hi Raj,
>>
>> Were you able to handle this logic as required?
>>
>> Thanks
>>
>> On Tue, Nov 24, 2015 at 2:00 PM, Reka Thirunavukkarasu <reka@wso2.com>
>> wrote:
>>
>>> +1 to check with mock IaaS as you mentioned since component started
>>> order is there..
>>>
>>> Thanks,
>>> Reka
>>>
>>> On Tue, Nov 24, 2015 at 1:58 PM, Rajkumar Rajaratnam <rajkumarr@wso2.com
>>> > wrote:
>>>
>>>> Hi Reka,
>>>>
>>>> $Subject + server restart test cases (STRATOS-1628 + STRATOS-1627) are
>>>> already implemented and available in 4.1.x branch. Since the component
>>>> startup order is CC > AS > SM > Mock, the solution works very well.
>>>>
>>>> CompleteTopologyEvent is published on demand now. Once
>>>> TopologyEventReceiver is started, it will request for
>>>> CompleteTopologyEvent. So by receiving CompleteTopologyEvent, we can't
>>>> ensure all the components of stratos are ready to serve requests.
>>>>
>>>> Thanks,
>>>> Raj.
>>>>
>>>> On Tue, Nov 24, 2015 at 1:14 PM, Reka Thirunavukkarasu <reka@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi Raj,
>>>>>
>>>>> +1 to introduce server restart test case. It is a good thought and
>>>>> would really be helpful in many ways and make sure persistence model
works
>>>>> properly.
>>>>>
>>>>> I'm not quite sure about whether we can only check mock IaaS API to
>>>>> see whether stratos started successfully. What about checking for the
>>>>> CompleteTopology message in TopologyHandler? Can we assume that server
>>>>> started successfully when CompleteTopology arrives from stratos?
>>>>>
>>>>> Thanks,
>>>>> Reka
>>>>>
>>>>> On Tue, Nov 24, 2015 at 11:41 AM, Rajkumar Rajaratnam <
>>>>> rajkumarr@wso2.com> wrote:
>>>>>
>>>>>> Hi Devs,
>>>>>>
>>>>>> Currently, integrations test is looking at specific log messages
to
>>>>>> determine whether the server is ready to handle request or not. I
propose
>>>>>> we need to handle this in the following way.
>>>>>>
>>>>>> a) exposing an API in mock API to check whether mock iaas is
>>>>>> activated or not.
>>>>>> b) integration tests should be started after getting a positive
>>>>>> response from the above API.
>>>>>>
>>>>>> As per our component start up order, the above solution will make
>>>>>> sure that every component is ready to handle requests. This is implemented
>>>>>> and available in 4.1.5 release. More information in [1].
>>>>>>
>>>>>> The main reason why I wanted this feature is to be able to write
the
>>>>>> server restart test case [2]. If we depends on logs, after server
restart,
>>>>>> integration tests will assume that the server is ready to handle
requests
>>>>>> because of the previous log messages.
>>>>>>
>>>>>> [1] https://issues.apache.org/jira/browse/STRATOS-1628
>>>>>> [2] https://issues.apache.org/jira/browse/STRATOS-1627
>>>>>>
>>>>>> Thanks,
>>>>>> Raj.
>>>>>>
>>>>>> --
>>>>>> Rajkumar Rajaratnam
>>>>>> Committer & PMC Member, Apache Stratos
>>>>>> Software Engineer, WSO2
>>>>>>
>>>>>> Mobile : +94777568639
>>>>>> Blog : rajkumarr.com
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Reka Thirunavukkarasu
>>>>> Senior Software Engineer,
>>>>> WSO2, Inc.:http://wso2.com,
>>>>> Mobile: +94776442007
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Rajkumar Rajaratnam
>>>> Committer & PMC Member, Apache Stratos
>>>> Software Engineer, WSO2
>>>>
>>>> Mobile : +94777568639
>>>> Blog : rajkumarr.com
>>>>
>>>
>>>
>>>
>>> --
>>> Reka Thirunavukkarasu
>>> Senior Software Engineer,
>>> WSO2, Inc.:http://wso2.com,
>>> Mobile: +94776442007
>>>
>>>
>>>
>>
>>
>> --
>> Imesh Gunaratne
>>
>> Senior Technical Lead, WSO2
>> Committer & PMC Member, Apache Stratos
>>
>
>
>
> --
> Rajkumar Rajaratnam
> Committer & PMC Member, Apache Stratos
> Software Engineer, WSO2
>
> Mobile : +94777568639
> Blog : rajkumarr.com
>



-- 
Imesh Gunaratne

Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos

Mime
View raw message