stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akila Ravihansa Perera <raviha...@wso2.com>
Subject Re: Introduce an Activated state to ApplicationContext
Date Tue, 15 Sep 2015 06:12:02 GMT
Great! I've merged the PR to stratos-4.1.x branch. Please update the JIRA.

On Tue, Sep 15, 2015 at 10:53 AM, Anuruddha Liyanarachchi <
anuruddhal@wso2.com> wrote:

> Hi All,
>
> Thanks for the clarification. I have now changed application signup button
>  to be enable only when application is active [1][2][3]. Also added remove
> signup button [4].
> Please merge the PR which contain changes [5].
>
> [1]
> https://drive.google.com/file/d/0B0v957zZwVWrdUEyOTJTUUtORlE/view?usp=sharing
> [2]
> https://drive.google.com/file/d/0B0v957zZwVWrZHpnUjQ5Y20tcGM/view?usp=sharing
> [3]
> https://drive.google.com/file/d/0B0v957zZwVWrOFFOeUY3V0lNLVE/view?usp=sharing
> [4]
> https://drive.google.com/file/d/0B0v957zZwVWrNllTMExfb18wajA/view?usp=sharing
> [5] https://github.com/apache/stratos/pull/464
>
> On Mon, Sep 14, 2015 at 6:40 PM, Imesh Gunaratne <imesh@apache.org> wrote:
>
>> Hi Anuruddha,
>>
>> I think what we need to use is ApplicationBean not the
>> ApplicationContext.
>>
>> On the Applications Overview page in the UI we use getApplications() API
>> method. If we can update this API method to return the Active state for
>> each application, we should be able to implement this logic in the UI.
>>
>> Thanks
>>
>> On Mon, Sep 14, 2015 at 11:09 AM, Reka Thirunavukkarasu <reka@wso2.com>
>> wrote:
>>
>>> Hi Anuruddha,
>>>
>>> ApplicationContext is not the runtime. It is a static reference to the
>>> application definition. In which we have a life cycle to identify whether
>>> it is created/deployed/undeploying. The actual runtime can be found in the
>>> Applications Topology where it already has the relevant life cycle. I think
>>> that you need to use applications runtime to check on the  relevant status.
>>>
>>> Thanks,
>>> Reka
>>>
>>> On Mon, Sep 14, 2015 at 10:13 AM, Anuruddha Liyanarachchi <
>>> anuruddhal@wso2.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> But we are not setting the ApplicationContext to active state when
>>>> application gets activated. We are only using three states [1].
>>>>
>>>> Don't we have to introduce "Active" state also to the
>>>> ApplicationContext and change UI, API and events accordingly.
>>>>
>>>> [1]
>>>> https://github.com/apache/stratos/blob/stratos-4.1.x/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/applications/pojo/ApplicationContext.java#L28-L30
>>>> <https://github.com/apache/stratos/blob/stratos-4.1.x/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/applications/pojo/ApplicationContext.java#L28-L30>
>>>>
>>>> On Thu, Sep 10, 2015 at 7:32 PM, Gayan Gunarathne <gayang@wso2.com>
>>>> wrote:
>>>>
>>>>> yeah. I think we already have that application active status.In
>>>>> integration tests we already checking this for assert the application
>>>>> activation. I think you can do the same here and allow sign up only when
>>>>> application is on active state.
>>>>>
>>>>> Thanks,
>>>>> Gayan
>>>>>
>>>>> On Thu, Sep 10, 2015 at 7:24 PM, Akila Ravihansa Perera <
>>>>> ravihansa@wso2.com> wrote:
>>>>>
>>>>>> Don't we already have an Active status [1] for Applications?
>>>>>>
>>>>>> [1]
>>>>>> https://github.com/apache/stratos/blob/stratos-4.1.x/components/org.apache.stratos.messaging/src/main/java/org/apache/stratos/messaging/domain/application/ApplicationStatus.java#L37
>>>>>>
>>>>>> On Thu, Sep 10, 2015 at 6:54 PM, Anuruddha Liyanarachchi <
>>>>>> anuruddhal@wso2.com> wrote:
>>>>>>
>>>>>>> Hi Devs,
>>>>>>>
>>>>>>> I am planing to do $subject in Stratos. This will prevent users
from
>>>>>>> signing-up before application is active.
>>>>>>>
>>>>>>> The application life cycle will be as [1].
>>>>>>>  WDYT?
>>>>>>>
>>>>>>> [1]
>>>>>>> https://docs.google.com/drawings/d/1XOVZkgp_UUpGvD_HykECU_8yoA2YWgfpqv6wX2mgacY/edit?usp=sharing
>>>>>>>
>>>>>>> --
>>>>>>> *Thanks and Regards,*
>>>>>>> Anuruddha Lanka Liyanarachchi
>>>>>>> Software Engineer - WSO2
>>>>>>> Mobile : +94 (0) 712762611
>>>>>>> Tel      : +94 112 145 345
>>>>>>> a <thilinad@wso2.com>nuruddhal@wso2.com
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Akila Ravihansa Perera
>>>>>> WSO2 Inc.;  http://wso2.com/
>>>>>>
>>>>>> Blog: http://ravihansa3000.blogspot.com
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> Gayan Gunarathne
>>>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>>>> Committer & PMC Member, Apache Stratos
>>>>> email : gayang@wso2.com  | mobile : +94 775030545 <%2B94%20766819985>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks and Regards,*
>>>> Anuruddha Lanka Liyanarachchi
>>>> Software Engineer - WSO2
>>>> Mobile : +94 (0) 712762611
>>>> Tel      : +94 112 145 345
>>>> a <thilinad@wso2.com>nuruddhal@wso2.com
>>>>
>>>
>>>
>>>
>>> --
>>> Reka Thirunavukkarasu
>>> Senior Software Engineer,
>>> WSO2, Inc.:http://wso2.com,
>>> Mobile: +94776442007
>>>
>>>
>>>
>>
>>
>> --
>> Imesh Gunaratne
>>
>> Senior Technical Lead, WSO2
>> Committer & PMC Member, Apache Stratos
>>
>
>
>
> --
> *Thanks and Regards,*
> Anuruddha Lanka Liyanarachchi
> Software Engineer - WSO2
> Mobile : +94 (0) 712762611
> Tel      : +94 112 145 345
> a <thilinad@wso2.com>nuruddhal@wso2.com
>



-- 
Akila Ravihansa Perera
WSO2 Inc.;  http://wso2.com/

Blog: http://ravihansa3000.blogspot.com

Mime
View raw message