stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From imesh <...@git.apache.org>
Subject [GitHub] stratos pull request: Google compute engine load balancing support...
Date Thu, 13 Aug 2015 03:55:57 GMT
Github user imesh commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/419#discussion_r36939218
  
    --- Diff: extensions/load-balancer/gce-extension/src/main/java/org/apache/stratos/gce/extension/GCEStatisticsReader.java
---
    @@ -0,0 +1,52 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.stratos.gce.extension;
    +
    +
    +import org.apache.stratos.common.constants.StratosConstants;
    +import org.apache.stratos.load.balancer.common.statistics.LoadBalancerStatisticsReader;
    +import org.apache.stratos.load.balancer.common.topology.TopologyProvider;
    +
    +/**
    + * GCE extension statistics reader class.
    + */
    +public class GCEStatisticsReader implements LoadBalancerStatisticsReader {
    +
    +    private TopologyProvider topologyProvider;
    +    private String clusterInstanceId;
    +
    +    public GCEStatisticsReader(TopologyProvider topologyProvider) {
    +        this.topologyProvider = topologyProvider;
    +        this.clusterInstanceId = System.getProperty(StratosConstants.
    +                CLUSTER_INSTANCE_ID, StratosConstants.NOT_DEFINED);
    +
    +    }
    +
    +    @Override
    +    public String getClusterInstanceId() {
    +        return clusterInstanceId;
    +    }
    +
    +    @Override
    +    public int getInFlightRequestCount(String clusterId) {
    +        //There is no way in GCE API to get in flight request count!
    --- End diff --
    
    Here we might need to say that its not possible to read the request count via the GCE
API at the moment. Say "no way" might be misleading at a different point of time if GCE introduce
a new API method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message