stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lahirus <...@git.apache.org>
Subject [GitHub] stratos pull request: Remove UUID and tenantId from CartridgeBean
Date Thu, 06 Aug 2015 16:24:35 GMT
Github user lahirus commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/418#discussion_r36434651
  
    --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java
---
    @@ -302,17 +302,17 @@ public Response addCartridge(
             }
             if (cartridgeBean != null) {
                 String msg = String.format("Cartridge already exists: [cartridge-type] %s
[cartridge-uuid] %s [tenant-id] %d",
    -                    cartridgeType,cartridgeDefinitionBean.getUuid(),cartridgeDefinitionBean.getTenantId());
    +                    cartridgeType, cartridgeUuid, tenantId);
                 log.warn(msg);
                 return Response.status(Response.Status.CONFLICT)
                         .entity(new ResponseMessageBean(ResponseMessageBean.ERROR, msg)).build();
             }
     
    -        StratosApiV41Utils.addCartridge(cartridgeDefinitionBean);
    +        StratosApiV41Utils.addCartridge(cartridgeDefinitionBean, cartridgeUuid, tenantId);
             URI url = uriInfo.getAbsolutePathBuilder().path(cartridgeType).build();
             return Response.created(url).entity(new ResponseMessageBean(ResponseMessageBean.SUCCESS,
                     String.format("Cartridge added successfully: [cartridge-type] %s [cartridge-uuid]
%s [tenant-id] %d",
    -                        cartridgeType,cartridgeDefinitionBean.getUuid(),cartridgeDefinitionBean.getTenantId()))).build();
    +                        cartridgeType,cartridgeUuid, tenantId))).build();
    --- End diff --
    
    Minor formatting issue: space missing after comma


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message