Return-Path: X-Original-To: apmail-stratos-dev-archive@minotaur.apache.org Delivered-To: apmail-stratos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BCA5D186EE for ; Wed, 29 Jul 2015 11:36:39 +0000 (UTC) Received: (qmail 70784 invoked by uid 500); 29 Jul 2015 11:36:33 -0000 Delivered-To: apmail-stratos-dev-archive@stratos.apache.org Received: (qmail 70728 invoked by uid 500); 29 Jul 2015 11:36:33 -0000 Mailing-List: contact dev-help@stratos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stratos.apache.org Delivered-To: mailing list dev@stratos.apache.org Received: (qmail 70718 invoked by uid 99); 29 Jul 2015 11:36:33 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2015 11:36:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8C4CD1A8AFA for ; Wed, 29 Jul 2015 11:36:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.15 X-Spam-Level: *** X-Spam-Status: No, score=3.15 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, HTML_MESSAGE=3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id XzqCH_v4RV_A for ; Wed, 29 Jul 2015 11:36:26 +0000 (UTC) Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com [209.85.213.179]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id D78E243CCD for ; Wed, 29 Jul 2015 11:36:25 +0000 (UTC) Received: by igbpg9 with SMTP id pg9so164635520igb.0 for ; Wed, 29 Jul 2015 04:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=L18JLQUDHDUM8JUQPaMestUqFGqphgRn7eL9qjCH6rY=; b=ZUXI4AofpZi6P1MjOtCTmhv6NxjDYJpkZl3jVFLy/QDgjAFMHTNhE3NHrlpPDfh8tT 4lsY6f351ZR+CM3Nnfi3qYLxjVVnWcaiA1Z/PfpSxWmL5/eAiUqtX2LKd2juxbH3izSM YneBkFflRyF8D29ttjQB2fVqMw//OzMT5NsZD/lllMqzSqkOC3F0Dsdy6VymBRDA9ePR JfHTh+eAwM5jP866r2WExhwXM/PjLdepA2SdtB9am5APygZwShtfk5suoJ8YeYpoMkzh aWwEbYL8BnSxkYdp2hrAJBKPs59U3sD+O5QJOL19UQpzPf40LHy7altZV/RxeQpGAzEP mFrA== MIME-Version: 1.0 X-Received: by 10.50.126.42 with SMTP id mv10mr722671igb.66.1438169740370; Wed, 29 Jul 2015 04:35:40 -0700 (PDT) Received: by 10.79.113.68 with HTTP; Wed, 29 Jul 2015 04:35:40 -0700 (PDT) Received: by 10.79.113.68 with HTTP; Wed, 29 Jul 2015 04:35:40 -0700 (PDT) In-Reply-To: References: Date: Wed, 29 Jul 2015 11:35:40 +0000 Message-ID: Subject: Re: Code Review meeting - AWS Load Balancing Support for Stratos From: Swapnil Patil To: dev Cc: Udara Liyanage , Imesh Gunaratne Content-Type: multipart/alternative; boundary=047d7b2e1219806892051c01fca6 --047d7b2e1219806892051c01fca6 Content-Type: text/plain; charset=UTF-8 Thanks Thanuja! I also need to catch specific exception and log appropriate message. Thanks and Regards, Swapnil On Jul 29, 2015 4:11 PM, "Thanuja Uruththirakodeeswaran" wrote: > Hi All, > > Please find the code review notes below: > > 1. Define used constant values as readable constant variables. > 2. Include loadbalancer name length constant (32) in the exception > message in AWSHelper class. > 3. In AWSLoadBalancer avoid using "if(clusterMemberSize()==0) break;" > and follow best coding practice. > 4. Use datatype for the integer sequence in AWSLoadBalancer. > 5. In AWSHelper, refactor setEndPoint method. > 6. Pass exception as second arguement in log.error() > 7. Don't declare method parameters as final in AWSHelper class. > 8. In AWSLoadBalancer remove instance logic as it is not needed. > 9. Add method comments. > > Thank you. > > On Wed, Jul 29, 2015 at 2:11 PM, Swapnil Patil > wrote: > >> Hi All, >> >> I have started hangout. You can join in for code review. >> >> URL: https://plus.google.com/hangouts/_/g7jnhpysd3dxyyrqycerhd6iyua >> >> Thanks and Regards, >> Swapnil >> >> On Mon, Jul 27, 2015 at 1:14 PM, Swapnil Patil >> wrote: >> >>> Hi Imesh, >>> >>> Ok. No problem. We can have this on Wednesday 29th July at 2 PM IST. >>> >>> Thanks and Regards, >>> Swapnil >>> On Jul 27, 2015 5:02 PM, "Imesh Gunaratne" wrote: >>> >>>> Hi Swapnil, >>>> >>>> I'm sorry I missed this, shall we have this on this Wednesday the 29th >>>> July at 2 PM IST? >>>> >>>> Thanks >>>> >>>> On Mon, Jul 27, 2015 at 2:23 PM, Swapnil Patil >>>> wrote: >>>> >>>>> It seems no one has joined yet. Shall we have it some other time? >>>>> >>>>> Thanks and Regards, >>>>> Swapnil >>>>> >>>>> On Mon, Jul 27, 2015 at 8:28 AM, Swapnil Patil >>>> > wrote: >>>>> >>>>>> Hi All, >>>>>> >>>>>> I have started a Google Hangout. You can join in for code review. >>>>>> >>>>>> Hangout URL: >>>>>> https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia >>>>>> >>>>>> Thanks and Regards, >>>>>> Swapnil >>>>>> >>>>>> On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil < >>>>>> swapnil.rp15@gmail.com> wrote: >>>>>> >>>>>>> Sure. Fine with me. >>>>>>> >>>>>>> Thanks and Regards, >>>>>>> Swapnil >>>>>>> >>>>>>> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne >>>>>>> wrote: >>>>>>> >>>>>>>> Shall we move this to 2 PM on the same day (27th July)? >>>>>>>> >>>>>>>> Thanks >>>>>>>> >>>>>>>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil < >>>>>>>> swapnil.rp15@gmail.com> wrote: >>>>>>>> >>>>>>>>> Hi All, >>>>>>>>> >>>>>>>>> I am planning to schedule a code review meeting for AWS extension >>>>>>>>> on Monday at 1 pm. >>>>>>>>> >>>>>>>>> Please feel free to let me know if you want to reschedule it at >>>>>>>>> different time or a day? >>>>>>>>> >>>>>>>>> Thanks and Regards, >>>>>>>>> Swapnil >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Imesh Gunaratne >>>>>>>> >>>>>>>> Senior Technical Lead, WSO2 >>>>>>>> Committer & PMC Member, Apache Stratos >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Imesh Gunaratne >>>> >>>> Senior Technical Lead, WSO2 >>>> Committer & PMC Member, Apache Stratos >>>> >>> >> > > > -- > Thanuja Uruththirakodeeswaran > Software Engineer > WSO2 Inc.;http://wso2.com > lean.enterprise.middleware > > mobile: +94 774363167 > --047d7b2e1219806892051c01fca6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Thanks Thanuja!

I also need to catch specific exception and log appropriate = message.

Thanks and Regards,
Swapnil

On Jul 29, 2015 4:11 PM, "Thanuja Uruththir= akodeeswaran" <thanujau@wso2.c= om> wrote:
Hi All,

Please find the code review notes= below:
  1. Define used constant values as readable constant = variables.
  2. Include loadbalancer name length constant (32) in th= e exception message in AWSHelper class.
  3. In AWSLoadBalancer avoi= d using "if(clusterMemberSize()=3D=3D0) break;" and follow best c= oding practice.
  4. Use datatype for the integer sequence in AWSLoa= dBalancer.
  5. In AWSHelper, refactor setEndPoint method.
    6. <= li>Pass exception as second arguement in log.error()
  6. Don't = declare method parameters as final in AWSHelper class.
  7. In AWSLo= adBalancer remove instance logic as it is not needed.
  8. Add metho= d comments.
Thank you.

On Wed, Jul 29, 2015 at 2:11 PM, Swapn= il Patil <swapnil.rp15@gmail.com> wrote:
Hi All,

I have star= ted hangout. You can join in for code review.


Thanks and Regards,
Swap= nil

On Mon, Jul 27, 2015 at 1:14 PM, Swapnil Patil &l= t;swapnil.rp15@= gmail.com> wrote:

Hi Imesh,

Ok. No problem. We can have this on Wednesday 29th July at 2= PM IST.

Thanks and Regards,
Swapnil

On Jul 27, 2015 5:02 PM, "Imesh Gunaratne&q= uot; <imesh@apache= .org> wrote:
=
Hi Swapnil,

I'm sorry I misse= d this, shall we have this on this Wednesday the 29th July at 2 PM IST?
Thanks

On Mon, Jul 27, 2015 at 2:23 PM, Swapnil Patil <sw= apnil.rp15@gmail.com> wrote:
It seems no one has joined yet. Shall we have it some ot= her time?

Thanks and Regards,
Swapnil

On M= on, Jul 27, 2015 at 8:28 AM, Swapnil Patil <swapnil.rp15@gmail.com> wrote:
Thanks and Regards,
Swapnil

On Sat, Jul 25, = 2015 at 2:38 AM, Swapnil Patil <swapnil.rp15@gmail.com>= wrote:
Sure. Fine with = me.

Thanks and Regards,
Swapnil

On Fri, Ju= l 24, 2015 at 5:59 PM, Imesh Gunaratne <imesh@apache.org> wro= te:
Shall we move this t= o 2 PM on the same day (27th July)?

Thanks

On Fri, J= ul 24, 2015 at 6:49 PM, Swapnil Patil <swapnil.rp15@gmail.com>= wrote:
Hi All,
I am planning to schedule a code review meeting for AWS e= xtension on Monday at 1 pm.

Please feel free to le= t me know if you want to reschedule it at different time or a day?

Thanks and Regards,
Swapnil=C2=A0



<= font color=3D"#888888">--
I= mesh Gunaratne

Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos<= /font>






--
=
Imesh Gunaratne

Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos
=




--
=
Thanuja Uruththirakod= eeswaran
Software Enginee= r
WSO2 Inc.;http://wso2.com
lean= .enterprise.middleware

mobile: +94 774363167
<= /div>
--047d7b2e1219806892051c01fca6--