stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From imesh <>
Subject [GitHub] stratos pull request: Service group validation
Date Wed, 06 May 2015 13:57:44 GMT
Github user imesh commented on a diff in the pull request:
    --- Diff: components/
    @@ -980,50 +981,41 @@ public static void addServiceGroup(GroupBean serviceGroupDefinition)
throws Rest
                 List<String> groupNames;
                 String[] cartridgeGroupNames;
    -            // if any cartridges are specified in the group, they should be already deployed
    -            if (serviceGroupDefinition.getCartridges() != null) {
    +            if (log.isDebugEnabled()) {
    +                log.debug("checking cartridges in cartridge group " + serviceGroupDefinition.getName());
    --- End diff --
    It might be better to make the first letter of log messages uppercase.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message