stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prabathabey <...@git.apache.org>
Subject [GitHub] stratos pull request: Refining cartridge classes in cloud controll...
Date Tue, 07 Apr 2015 05:50:24 GMT
Github user prabathabey commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/277#discussion_r27852793
  
    --- Diff: components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/context/CloudControllerContext.java
---
    @@ -729,4 +740,97 @@ private void copyList(List sourceList, List destinationList) {
                 destinationList.add(item);
             }
         }
    +
    +    public Map<String, Map<String, IaasProvider>> getPartitionToIaasProviderByCartridge()
{
    +        return partitionToIaasProviderByCartridge;
    +    }
    +
    +    public void setPartitionToIaasProvider(Map<String, Map<String, IaasProvider>>
partitionToIaasProviderByCartridge) {
    +        this.partitionToIaasProviderByCartridge = partitionToIaasProviderByCartridge;
    +    }
    +
    +    public void addIaasProvider(String cartridgeType, String partitionId, IaasProvider
iaasProvider) {
    +        Map<String, IaasProvider> partitionToIaasProvider = new ConcurrentHashMap<String,
IaasProvider>();
    +        partitionToIaasProvider.put(partitionId, iaasProvider);
    +        this.partitionToIaasProviderByCartridge.put(cartridgeType, partitionToIaasProvider);
    +    }
    +
    +    public void addIaasProviders(String cartridgeType, Map<String, IaasProvider>
map) {
    --- End diff --
    
    This line would have been much readable if some other meaningful name was used to replace
the variable name "map".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message