Return-Path: X-Original-To: apmail-stratos-dev-archive@minotaur.apache.org Delivered-To: apmail-stratos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C123317C00 for ; Wed, 25 Mar 2015 01:13:07 +0000 (UTC) Received: (qmail 35373 invoked by uid 500); 25 Mar 2015 01:13:07 -0000 Delivered-To: apmail-stratos-dev-archive@stratos.apache.org Received: (qmail 35316 invoked by uid 500); 25 Mar 2015 01:13:07 -0000 Mailing-List: contact dev-help@stratos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stratos.apache.org Delivered-To: mailing list dev@stratos.apache.org Received: (qmail 35306 invoked by uid 99); 25 Mar 2015 01:13:07 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Mar 2015 01:13:07 +0000 Received: from mail-qg0-f51.google.com (mail-qg0-f51.google.com [209.85.192.51]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 5B3031A0026 for ; Wed, 25 Mar 2015 01:13:07 +0000 (UTC) Received: by qgh3 with SMTP id 3so8973642qgh.2 for ; Tue, 24 Mar 2015 18:13:06 -0700 (PDT) X-Received: by 10.140.98.2 with SMTP id n2mr8913267qge.62.1427245986194; Tue, 24 Mar 2015 18:13:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.75.2 with HTTP; Tue, 24 Mar 2015 18:12:45 -0700 (PDT) In-Reply-To: References: From: Imesh Gunaratne Date: Wed, 25 Mar 2015 06:42:45 +0530 Message-ID: Subject: Re: "isVolumeRequired" is required when persistence section is mentioned? To: dev Content-Type: multipart/alternative; boundary=001a113ab83403ae830512129a56 --001a113ab83403ae830512129a56 Content-Type: text/plain; charset=UTF-8 +1 A good point Lahiru, we will not need a separate property for this. Thanks On Wed, Mar 25, 2015 at 12:21 AM, Udara Liyanage wrote: > Hi, > > Earlier we used this property in service definition so it can switch > on/off with this property. Yes we can get rid of this. > On 24 Mar 2015 23:04, "Lahiru Sandaruwan" wrote: > >> Hi all, >> >> In the new model, we get the persistence volume details in >> subscribableInfo. As per older implementations we had "isVolumeRequired" >> field, where we got the information from cartridge definition. >> >> IMO we can get rid of this field since user can specify the persistence >> portion of the json when it is really required. >> >> Any objections? >> >> Thanks. >> >> -- >> -- >> Lahiru Sandaruwan >> Committer and PMC member, Apache Stratos, >> Senior Software Engineer, >> WSO2 Inc., http://wso2.com >> lean.enterprise.middleware >> >> phone: +94773325954 >> email: lahirus@wso2.com blog: http://lahiruwrites.blogspot.com/ >> linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146 >> >> -- Imesh Gunaratne Technical Lead, WSO2 Committer & PMC Member, Apache Stratos --001a113ab83403ae830512129a56 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
+1 A good point Lahiru, we will not need a separate proper= ty for this.

Thanks

On Wed, Mar 25, 2015 at 12:21 AM, Udara Li= yanage <udara@wso2.com> wrote:
Hi,

Earlier we used this property in service definition so it ca= n switch on/off with this property. Yes we can get rid of this.

On 24 Mar 2015 23:04, "Lahiru Sandaruwan&qu= ot; <lahirus@wso2.= com> wrote:
<= div dir=3D"ltr">Hi all,

In the new model, we get the per= sistence volume details in subscribableInfo. As per older implementations w= e had "isVolumeRequired" field, where we got the information from cartridge=C2=A0de= finition.=C2=A0

= IMO we can get rid of this field since use= r can specify the persistence portion of the json when it is really require= d.=C2=A0

Any objections?

Thanks.

--
--
Lahiru Sandaruwan=
Committer and PMC member,= Apache Stratos,
Senior=C2=A0Software Engineer,
WSO2 Inc., http://wso2.com



--
=
Imesh Gunaratne

Technical Lead, WSO2
Committer & PMC Mem= ber, Apache Stratos
--001a113ab83403ae830512129a56--