Return-Path: X-Original-To: apmail-stratos-dev-archive@minotaur.apache.org Delivered-To: apmail-stratos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B025917562 for ; Thu, 26 Mar 2015 13:49:02 +0000 (UTC) Received: (qmail 18748 invoked by uid 500); 26 Mar 2015 13:49:02 -0000 Delivered-To: apmail-stratos-dev-archive@stratos.apache.org Received: (qmail 18697 invoked by uid 500); 26 Mar 2015 13:49:02 -0000 Mailing-List: contact dev-help@stratos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stratos.apache.org Delivered-To: mailing list dev@stratos.apache.org Received: (qmail 18687 invoked by uid 99); 26 Mar 2015 13:49:02 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Mar 2015 13:49:02 +0000 Received: from mail-qg0-f43.google.com (mail-qg0-f43.google.com [209.85.192.43]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id C1C0C1A0466 for ; Thu, 26 Mar 2015 13:49:01 +0000 (UTC) Received: by qgh3 with SMTP id 3so82825332qgh.2 for ; Thu, 26 Mar 2015 06:49:00 -0700 (PDT) X-Received: by 10.55.23.161 with SMTP id 33mr29610876qkx.62.1427377738067; Thu, 26 Mar 2015 06:48:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.75.2 with HTTP; Thu, 26 Mar 2015 06:48:37 -0700 (PDT) In-Reply-To: References: <6899B95749E44F43BF2128D9A4FD000C06297E41@xmb-rcd-x09.cisco.com> <6899B95749E44F43BF2128D9A4FD000C062A2935@xmb-aln-x09.cisco.com> <6899B95749E44F43BF2128D9A4FD000C062B2372@xmb-rcd-x09.cisco.com> <6899B95749E44F43BF2128D9A4FD000C062B2523@xmb-rcd-x09.cisco.com> From: Imesh Gunaratne Date: Thu, 26 Mar 2015 19:18:37 +0530 Message-ID: Subject: Re: Schema changes for Stratos 4.1 To: dev Content-Type: multipart/alternative; boundary=001a11473bb209b8900512314789 --001a11473bb209b8900512314789 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable It looks like I have done the fix on a previous commit, I did not see the initialization in constructors. I just fixed it again. Thanks On Thu, Mar 26, 2015 at 6:30 PM, Udara Liyanage wrote: > Hi Imesh, > > properties variable is initialized in both constructors. Do we have to > initialize it again in init() > > On Thu, Mar 26, 2015 at 6:22 PM, Imesh Gunaratne wrote= : > >> The above fix was not in the latest codebase. I just applied it and >> pushed to master branch. >> >> Thanks >> >> On Wed, Mar 25, 2015 at 6:09 PM, Shaheedur Haque (shahhaqu) < >> shahhaqu@cisco.com> wrote: >> >>> Unfortunately, 276f1f162f authored 2 hours ago does not fix the issue. >>> I presume this is because it does not cover the default constructor, bu= t I >>> am not sure. >>> >>> >>> >>> *From:* Udara Liyanage [mailto:udara@wso2.com] >>> *Sent:* Wednesday, March 25, 2015 10:57 AM >>> >>> *To:* dev >>> *Subject:* Re: Schema changes for Stratos 4.1 >>> >>> >>> >>> Hi Shaheed, >>> >>> >>> >>> I think your fix is valid. properties variable is not initialized befor= e >>> adding property. I will commit the fix. >>> >>> Thanks for suggesting the fix. >>> >>> >>> >>> On Wed, Mar 25, 2015 at 3:43 PM, Shaheedur Haque (shahhaqu) < >>> shahhaqu@cisco.com> wrote: >>> >>> Hi all, >>> >>> >>> >>> With master at 69a5eb from a few hours ago, and the following temporar= y >>> fix: >>> >>> >>> >>> $ git diff >>> >>> diff --git >>> a/components/org.apache.stratos.cloud.controller/src/main/java/org/apac= he/stratos/cloud/controller/domain/Cartridge.ja >>> >>> index 4c1a690..5072dcd 100644 >>> >>> --- >>> a/components/org.apache.stratos.cloud.controller/src/main/java/org/apac= he/stratos/cloud/controller/domain/Cartridge.java >>> >>> +++ >>> b/components/org.apache.stratos.cloud.controller/src/main/java/org/apac= he/stratos/cloud/controller/domain/Cartridge.java >>> >>> @@ -78,6 +78,7 @@ public class Cartridge implements Serializable{ >>> >>> >>> >>> private void init() { >>> >>> tenantPartitions =3D "*"; >>> >>> + properties =3D new org.apache.stratos.common.Properties(); >>> >>> } >>> >>> >>> >>> public String getType() { >>> >>> >>> >>> I can now see volumes being attached correctly. So, pending an official >>> version of the above fix, I will consider this issue as closed form my = POV. >>> >>> >>> >>> Thanks, Shaheed >>> >>> >>> >>> *From:* Imesh Gunaratne [mailto:imesh@apache.org] >>> *Sent:* Saturday, March 14, 2015 5:59 AM >>> *To:* dev >>> *Subject:* Re: Schema changes for Stratos 4.1 >>> >>> >>> >>> Hi Devs, >>> >>> >>> >>> Thanks Shaheed for brining this up. @Devs I think we need to add the >>> persistence attribute to the Subscribable information section and imple= ment >>> any logic required in the backend. >>> >>> >>> >>> Thanks >>> >>> >>> >>> On Fri, Mar 13, 2015 at 9:26 PM, Shaheedur Haque (shahhaqu) < >>> shahhaqu@cisco.com> wrote: >>> >>> Imesh and I discussed this, and it was agreed that this seems to be >>> missing. Imesh undertook to investigate and report back. >>> >>> >>> >>> *From:* Shaheedur Haque (shahhaqu) >>> *Sent:* 12 March 2015 16:23 >>> *To:* dev@stratos.apache.org >>> *Subject:* Schema changes for Stratos 4.1 >>> >>> >>> >>> Hi Imesh, >>> >>> >>> >>> I=E2=80=99m busy porting our code to the new model. One issue I have ju= st come >>> across is that in the old model, the =E2=80=9Cpersistence=E2=80=9D attr= ibute was available >>> (as I understand it) on both the Cartridge Definition and also on the >>> Cartridge Subscription. For reasons I am sure you will understand, we m= ust >>> apply the attribute on the Subscription. I don=E2=80=99t quite see how/= where to do >>> this in the new model. Have I missed something? >>> >>> >>> >>> Also, this begs the question whether there are any other attributes on >>> the old Subscription that have not made it into the new model. It would >>> probably be a good idea to a quick/urgent review of this using the >>> comparison document you published=E2=80=A6WDYT? >>> >>> >>> >>> Finally, did you see my comment on the comparison doc about the >>> cartridgeMin/Max values? >>> >>> >>> >>> Thanks, Shaheed >>> >>> >>> >>> >>> >>> >>> >>> -- >>> >>> Imesh Gunaratne >>> >>> >>> >>> Technical Lead, WSO2 >>> >>> Committer & PMC Member, Apache Stratos >>> >>> >>> >>> >>> >>> -- >>> >>> >>> Udara Liyanage >>> >>> Software Engineer >>> >>> WSO2, Inc.: http://wso2.com >>> >>> lean. enterprise. middleware >>> >>> web: http://udaraliyanage.wordpress.com >>> >>> phone: +94 71 443 6897 >>> >> >> >> >> -- >> Imesh Gunaratne >> >> Technical Lead, WSO2 >> Committer & PMC Member, Apache Stratos >> > > > > -- > > Udara Liyanage > Software Engineer > WSO2, Inc.: http://wso2.com > lean. enterprise. middleware > > web: http://udaraliyanage.wordpress.com > phone: +94 71 443 6897 > --=20 Imesh Gunaratne Technical Lead, WSO2 Committer & PMC Member, Apache Stratos --001a11473bb209b8900512314789 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
It looks like I have done the fix on a previous commit, I = did not see the initialization in constructors. I just fixed it again.
=
Thanks

On Thu, Mar 26, 2015 at 6:30 PM, Udara Liyanage <udara@wso2= .com> wrote:
Hi Imesh,

properties variable is initialized in both = constructors. Do we have to initialize it again in init()

On Thu, Mar 26, 2015 at 6:22 PM, Imesh Gunaratne <imesh@ap= ache.org> wrote:
The above fix was not in the latest codebase. I just applied it an= d pushed to master branch.

Thanks
<= div class=3D"gmail_extra">
On Wed, Mar 25, 20= 15 at 6:09 PM, Shaheedur Haque (shahhaqu) <shahhaqu@cisco.com> wrote:

Unfortunately, 276f1f162f authored 2 = hours ago does not fix the issue. I presume this is because it does not cov= er the default constructor, but I am not sure.

=C2=A0

From: Udara Liyanage [mailto:udara@wso2.com]
Sent: Wednesday, March 25, 2015 10:57 AM


To: dev
Subject: Re: Schema changes for Stratos 4.1

=C2=A0

Hi Shaheed,

=C2=A0

I think your fix is valid. properties variable is no= t initialized before adding property. I will commit the fix.<= /p>

Thanks for suggesting the fix.

=C2=A0

On Wed, Mar 25, 2015 at 3:43 PM, Shaheedur Haque (sh= ahhaqu) <shahhaq= u@cisco.com> wrote:

Hi all,

=C2=A0

With master at 69a5eb from =C2=A0a fe= w hours ago, and the following temporary fix:

=C2=A0

$ git diff

diff --git a/components/org.apache.stratos.cloud.controller/= src/main/java/org/apache/stratos/cloud/controller/domain/Cartridge.ja

index 4c1a690..5072dcd 100644

--- a/components/org.apache.stratos.cloud.controller/src/mai= n/java/org/apache/stratos/cloud/controller/domain/Cartridge.java<= /u>

+++ b/components/org.apache.stratos.cloud.controller/src/mai= n/java/org/apache/stratos/cloud/controller/domain/Cartridge.java<= /u>

@@ -78,6 +78,7 @@ public class Cartridge implements Serializ= able{

=C2=A0=C2=A0=C2=A0=C2=A0

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0private void init() {

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tenantParti= tions =3D "*";

+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 properties =3D n= ew org.apache.stratos.common.Properties();

=C2=A0=C2=A0=C2=A0=C2=A0 }

=C2=A0

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0public String getType() {

=C2=A0

I can now see volumes being attached = correctly. So, pending an official version of the above fix, I will consider this issue as closed form my POV.

=C2=A0

Thanks, Shaheed<= /p>

=C2=A0

From: Imesh Gunaratne [mailto:imesh@apache.org]
Sent: Saturday, March 14, 2015 5:59 AM
To: dev
Subject: Re: Schema changes for Stratos 4.1

=C2=A0

Hi Devs,

=C2=A0

Thanks Shaheed for brining this up. @Devs I think we= need to add the persistence attribute to the Subscribable information sect= ion and implement any logic required in the backend.

=C2=A0

Thanks

=C2=A0

On Fri, Mar 13, 2015 at 9:26 PM, Shaheedur Haque (sh= ahhaqu) <shahhaq= u@cisco.com> wrote:

Imesh and I discussed = this, and it was agreed that this seems to be missing. Imesh undertook to investigate and report back.

=C2=A0

From: Shaheedur Haque (shahhaqu)
Sent: 12 March 2015 16:23
To: dev@= stratos.apache.org
Subject: Schema changes for Stratos 4.1

=C2=A0

Hi Imesh,

=C2=A0

I=E2=80=99m busy porting our code to= the new model. One issue I have just come across is that in the old model, the =E2=80=9Cpersistence=E2=80=9D attribute was available (as I understand= it) on both the Cartridge Definition and also on the Cartridge Subscriptio= n. For reasons I am sure you will understand, we must apply the attribute o= n the Subscription. I don=E2=80=99t quite see how/where to do this in the new model. Have I missed something?=

=C2=A0

Also, this begs the question whether= there are any other attributes on the old Subscription that have not made it into the new model. It would probably be a good idea to a quic= k/urgent review of this using the comparison document you published=E2=80= =A6WDYT?

=C2=A0

Finally, did you see my comment on t= he comparison doc about the cartridgeMin/Max values?

=C2=A0

Thanks, Shaheed=

=C2=A0



=C2=A0

--

Imesh Gunaratne

=C2=A0

Technical Lead, WSO2

Committer & PMC Member, Apache Stratos=



=C2=A0

--


Udara Liyanage

Software Engineer

WSO2, Inc.:=C2=A0= http://wso2.com

lean. enterprise. middlew= are

phone:=C2=A0+94 = 71 443 6897




--
Imesh Gunaratne

Technical Lead, WSO2
Committer & PMC Member, Apache Stratos
=



--
=

Udara LiyanageSoftware Engineer=
WSO2, Inc.:=C2=A0http://wso2.com
lean. enterprise. middleware

= phone:=C2=A0+94 71 443 6897



--
=
Imesh Gunaratne

Technical Lead, WSO2
Committer & PMC Mem= ber, Apache Stratos
--001a11473bb209b8900512314789--