stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From imesh <...@git.apache.org>
Subject [GitHub] stratos pull request: Refining cartridge classes in cloud controll...
Date Tue, 24 Mar 2015 11:30:14 GMT
Github user imesh commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/277#discussion_r27019381
  
    --- Diff: components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/context/CloudControllerContext.java
---
    @@ -161,6 +158,20 @@
     	 */
     	private Map<String, NetworkPartition> networkPartitionIDToNetworkPartitionMap;
     
    +
    +    /**
    +     * Key - cartridge id (cartridge type is used as an unique identifier)
    --- End diff --
    
    IMO it would be better to use Cartridge Type instead of Cartridge ID as we are already
using Cartridge Type as the key of the cartridge.
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message