stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From imesh <...@git.apache.org>
Subject [GitHub] stratos pull request: Raising registry exception for adding autosc...
Date Fri, 06 Mar 2015 12:54:49 GMT
Github user imesh commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/215#discussion_r25942573
  
    --- Diff: components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/registry/RegistryManager.java
---
    @@ -118,19 +118,33 @@ private void persist(Object dataObj, String resourcePath) throws
AutoScalerExcep
         }
     
         public void persistAutoscalerPolicy(AutoscalePolicy autoscalePolicy) {
    -        String resourcePath = AutoscalerConstants.AUTOSCALER_RESOURCE + AutoscalerConstants.AS_POLICY_RESOURCE
+ "/" + autoscalePolicy.getId();
    -        persist(autoscalePolicy, resourcePath);
    -        if (log.isDebugEnabled()) {
    -            log.debug(String.format("Autoscaler policy written to registry: [id] %s [name]
%s [description] %s",
    -                    autoscalePolicy.getId(), autoscalePolicy.getDisplayName(), autoscalePolicy.getDescription()));
    +        try {
    +            String resourcePath = AutoscalerConstants.AUTOSCALER_RESOURCE +
    +                    AutoscalerConstants.AS_POLICY_RESOURCE + "/" + autoscalePolicy.getId();
    +
    +            persist(autoscalePolicy, resourcePath);
    +            if (log.isDebugEnabled()) {
    +                log.debug(String.format("Autoscaler policy written to registry: [id]
%s [name] %s [description] %s",
    +                        autoscalePolicy.getId(), autoscalePolicy.getDisplayName(), autoscalePolicy.getDescription()));
    +            }
    +        } catch (Exception e) {
    +            log.error((String.format("Unable to persist autoscaler policy [autoscaler-policy-id]
%s",
    +                    autoscalePolicy.getId())), e);
    --- End diff --
    
    Yes please close this as we have done the same fix in a different pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message