Return-Path: X-Original-To: apmail-stratos-dev-archive@minotaur.apache.org Delivered-To: apmail-stratos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3A55B173C2 for ; Thu, 5 Feb 2015 09:58:56 +0000 (UTC) Received: (qmail 96479 invoked by uid 500); 5 Feb 2015 09:58:56 -0000 Delivered-To: apmail-stratos-dev-archive@stratos.apache.org Received: (qmail 96434 invoked by uid 500); 5 Feb 2015 09:58:55 -0000 Mailing-List: contact dev-help@stratos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stratos.apache.org Delivered-To: mailing list dev@stratos.apache.org Received: (qmail 96421 invoked by uid 99); 5 Feb 2015 09:58:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2015 09:58:55 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 05 Feb 2015 09:58:54 +0000 Received: (qmail 95124 invoked by uid 99); 5 Feb 2015 09:58:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2015 09:58:34 +0000 Date: Thu, 5 Feb 2015 09:58:34 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@stratos.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (STRATOS-1174) Fix broken code segments in defaultextensionhandler.py in Python cartridge agent MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/STRATOS-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306933#comment-14306933 ] ASF GitHub Bot commented on STRATOS-1174: ----------------------------------------- GitHub user chamilad opened a pull request: https://github.com/apache/stratos/pull/206 [STRATOS-1174] - Fix and cleanup broken code on defaultextensionhandler.py In this fix, I've resolved undeclared variables, unused variables and unnecessary exception handling. Additionally a code cleanup was done according to PEP You can merge this pull request into a Git repository by running: $ git pull https://github.com/chamilad/stratos stratos-1174 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/stratos/pull/206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #206 ---- commit 2c1a8cf5510e42866875f9ad926e5c6d5809239e Author: Chamila de Alwis Date: 2015-02-05T09:46:15Z Fixed missing variable declarations, unused variables in defaultextensionhandler.py Removed unused code in defaultextensionhandler.py commit 4edb500dc6bb47dbf2c5069d316c165f8aa25512 Author: Chamila de Alwis Date: 2015-02-05T09:51:24Z Code cleanup on defaultextensionhandler.py ---- > Fix broken code segments in defaultextensionhandler.py in Python cartridge agent > -------------------------------------------------------------------------------- > > Key: STRATOS-1174 > URL: https://issues.apache.org/jira/browse/STRATOS-1174 > Project: Stratos > Issue Type: Task > Components: Cartridge Agent > Reporter: Chamila de Alwis > Fix For: 4.1.0 RC1 > > Original Estimate: 1h > Remaining Estimate: 1h > > Some of the extension related code seems to be broken because of a code cleanup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)