stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gayan Gunarathne <gay...@wso2.com>
Subject Re: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id
Date Wed, 18 Feb 2015 04:52:43 GMT
Hi Martin,

Thanks for identify that.It needs to be compare application ID. I have
fixed that now.

Hi Imesh,

That part is didn't test since we have some issue with PCA git repo cloning
at that time. But I guess now we can do the end to end testing on this.

Thanks,
Gayan


On Wed, Feb 18, 2015 at 9:19 AM, Imesh Gunaratne <imesh@apache.org> wrote:

> Hi Martin,
>
> Thanks for identifying this, yes it seems like a bug. Gayan did we test
> this?
>
> IMO we need to compare the Application ID sent in the Application SignUp
> Removal event against the Application ID in the payload, then if the
> tenant's Git repository is already cloned we need to remove it.
>
> Thanks
>
> On Wed, Feb 18, 2015 at 3:06 AM, Martin Eppel (meppel) <meppel@cisco.com>
> wrote:
>
>>  In extensionhandler.py we compare in “
>> *on_application_signup_removal_event*” method service_name with
>> applicationId, is this a bug or intentional ?
>>
>>
>>
>> See snippet:
>>
>>
>>
>>
>>
>> def on_application_signup_removal_event(self,
>> application_signup_removal_event):
>>
>>         self.log.info(
>>
>>             "Tenant unsubscribed event received: [tenant] " +
>> application_signup_removal_event.tenantId +
>>
>>             " [application ID] " +
>> application_signup_removal_event.applicationId
>>
>>         )
>>
>>
>>
>>         *if self.cartridge_agent_config.service_name ==
>> application_signup_removal_event.applicationId:*
>>
>>
>> agentgithandler.AgentGitHandler.remove_repo(application_signup_removal_event.tenant_id)
>>
>>
>>
>>         extensionutils.execute_application_signup_removal_extension({})
>>
>
>
>
> --
> Imesh Gunaratne
>
> Technical Lead, WSO2
> Committer & PMC Member, Apache Stratos
>



-- 

Gayan Gunarathne
Technical Lead
WSO2 Inc. (http://wso2.com)
email  : gayang@wso2.com  | mobile : +94 766819985

Mime
View raw message