stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STRATOS-1092) Validate before removal of cartridges and cartridge groups
Date Mon, 26 Jan 2015 01:09:35 GMT

    [ https://issues.apache.org/jira/browse/STRATOS-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291336#comment-14291336
] 

ASF GitHub Bot commented on STRATOS-1092:
-----------------------------------------

GitHub user shirolk opened a pull request:

    https://github.com/apache/stratos/pull/186

    Add validation priori to removal of cartridges and cartridge groups

    The purpose of the pull request is to incorporate validation when either a cartridge or
cartridge group is removed - essentially these can only be remove if they are not included
in either cartridge groups or applications.
    This fixes STRATOS-1092
    
    Performed the following testing on this PR.
    1. add cartridge - remove cartridge = OK
    2. add cartridge - add application with cartridge - remove cartridge = OK
    3. add cartridge - add service group - remove cartridge = OK
    4. add cartridge - add service group - add application with service group and cartridge
- remove service group - remove cartirdge = OK


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shirolk/stratos master-validate-c-cg-removal

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/stratos/pull/186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #186
    
----
commit 74b9b22e92d7761014cea05d60e91d85f8eda697
Author: Shiro <shiro@wso2.com>
Date:   2015-01-23T11:44:49Z

    Added functionality to do validation before cartridge and cartridgeGroup removal

commit b5075fb64b68d94f9b8d634750208b2435a8e7cb
Author: Shiro <shiro@wso2.com>
Date:   2015-01-23T15:18:01Z

    Fixed a few issues in validation proceedures

commit cae97c3860dde90cb88014ea22c695210b60799f
Author: Shiro <shiro@wso2.com>
Date:   2015-01-23T11:44:49Z

    Added functionality to do validation before cartridge and cartridgeGroup removal

commit fa0292b3d4b5ad02eb36834c59e5ef62c0e14144
Author: Shiro <shiro@wso2.com>
Date:   2015-01-23T15:18:01Z

    Fixed a few issues in validation proceedures

commit 46ac684ea6ddc742c4ff9b25cc27d6f0a7fe559e
Author: Shiro <shiro@wso2.com>
Date:   2015-01-26T01:01:09Z

    Fixed merge conflict

----


> Validate before removal of cartridges and cartridge groups
> ----------------------------------------------------------
>
>                 Key: STRATOS-1092
>                 URL: https://issues.apache.org/jira/browse/STRATOS-1092
>             Project: Stratos
>          Issue Type: Improvement
>          Components: Autoscaler, CC
>    Affects Versions: 4.1.0 Alpha
>            Reporter: Shiroshica Kulatilake
>            Assignee: Shiroshica Kulatilake
>             Fix For: 4.1.0 RC1
>
>
> When cartridges and cartridge groups are deleted a validation should be done pre deletion
to make sure that 
> 1. The cartridge does not exist in a cartridge group or application
> 2. The cartridge group does not exist in another group or application 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message