stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From imesh <...@git.apache.org>
Subject [GitHub] stratos pull request: Modification to Thrift-Client-Configuration
Date Sat, 31 Jan 2015 17:38:03 GMT
Github user imesh commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/200#discussion_r23890505
  
    --- Diff: components/org.apache.stratos.common/src/main/java/org/apache/stratos/common/statistics/publisher/ThriftClientConfigParser.java
---
    @@ -0,0 +1,113 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *  http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.stratos.common.statistics.publisher;
    +
    +import org.apache.axiom.om.OMElement;
    +import org.apache.stratos.common.util.AxiomXpathParserUtil;
    +
    +import java.io.File;
    +import java.util.Iterator;
    +
    +/**
    + * Thrift Client config parser.
    + */
    +public class ThriftClientConfigParser {
    +    /**
    +     * Fields to be read from the thrift-client-config.xml file
    +     */
    +    private static final String USERNAME_ELEMENT = "username";
    +    private static final String PASSWORD_ELEMENT = "password";
    +    private static final String IP_ELEMENT = "ip";
    +    private static final String PORT_ELEMENT = "port";
    +
    +    /**
    +     * This method reads thrift-client-config.xml file and assign necessary credential
    +     * values into thriftClientInfo object.  A singleton design has been implemented
    +     * with the use of thriftClientIConfig class.
    +     * <p>
    +     * The filePath argument is the path to thrift-client-config.xml file
    +     *
    +     * @param filePath the path to thrift-client-config.xml file
    +     * @return         ThriftClientConfig object
    +     */
    +    public static ThriftClientConfig parse(String filePath) {
    +        try {
    +            ThriftClientConfig thriftClientIConfig = new ThriftClientConfig();
    +            ThriftClientInfo thriftClientInfo = new ThriftClientInfo();
    +            thriftClientIConfig.setThriftClientInfo(thriftClientInfo);
    +
    +            OMElement document = AxiomXpathParserUtil.parse(new File(filePath));
    +            Iterator thriftClientIterator = document.getChildElements();
    +
    +            String userNameValuesStr = null;
    +            String passwordValueStr = null;
    +            String ipValuesStr = null;
    +            String portValueStr = null;
    +
    +            // Iterate the thrift-client-config.xml file and read child element
    +            // consists of credential information necessary for WSO2CEPStatisticsPublisher
    +            while (thriftClientIterator.hasNext()) {
    +                OMElement thriftClientElement = (OMElement) thriftClientIterator.next();
    +
    +                if (USERNAME_ELEMENT.equals(thriftClientElement.getQName().getLocalPart()))
{
    +                    userNameValuesStr = thriftClientElement.getText();
    +                    thriftClientInfo.setUsername(userNameValuesStr);
    +                }
    +
    +                if (PASSWORD_ELEMENT.equals(thriftClientElement.getQName().getLocalPart()))
{
    +                    passwordValueStr = thriftClientElement.getText();
    +                    thriftClientInfo.setPassword(passwordValueStr);
    +                }
    +
    +                if (IP_ELEMENT.equals(thriftClientElement.getQName().getLocalPart()))
{
    +                    ipValuesStr = thriftClientElement.getText();
    +                    thriftClientInfo.setIp(ipValuesStr);
    +                }
    +
    +                if (PORT_ELEMENT.equals(thriftClientElement.getQName().getLocalPart()))
{
    +                    portValueStr = thriftClientElement.getText();
    +                    thriftClientInfo.setPort(portValueStr);
    +                }
    +            }
    +
    +            if (userNameValuesStr == null) {
    +                throw new RuntimeException("Username value not found in thrift Client
Configuration");
    +            }
    --- End diff --
    
    Shall we make the character "C" lower case: "client configuration"?
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message