stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swgkg <...@git.apache.org>
Subject [GitHub] stratos pull request: Re-factoring of the meta data service
Date Fri, 19 Dec 2014 11:21:03 GMT
Github user swgkg commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/84#discussion_r22100008
  
    --- Diff: components/org.apache.stratos.metadataservice/src/main/java/org/apache/stratos/metadataservice/registry/CarbonRegistry.java
---
    @@ -31,44 +31,121 @@
     import org.wso2.carbon.registry.api.Registry;
     import org.wso2.carbon.registry.api.RegistryException;
     import org.wso2.carbon.registry.api.Resource;
    -import org.wso2.carbon.registry.core.service.RegistryService;
    +
    +
    +/**
    + * Carbon registry implementation
    + */
     
     public class CarbonRegistry extends AbstractAdmin implements DataStore {
     
    -	private static Log log = LogFactory.getLog(CarbonRegistry.class);
    -	@Context
    -	HttpServletRequest httpServletRequest;
    +    private static Log log = LogFactory.getLog(CarbonRegistry.class);
    +    @Context
    +    HttpServletRequest httpServletRequest;
     
    -	private static ConfigurationContext configContext = null;
    +    private static final String mainResource = "/startos/";
     
    -	private static String defaultAxis2Repo = "repository/deployment/client";
    -	private static String defaultAxis2Conf = "repository/conf/axis2/axis2_client.xml";
     
    -	private static final String defaultUsername = "admin@org.com";
    -	private static final String defaultPassword = "admin123";
    -	private static final String serverURL = "https://localhost:9445/services/";
    -	private static final String mainResource = "/stratos/";
    -	private static final int defaultRank = 3;
    -	private RegistryService registryService;
    +    public CarbonRegistry() {
     
    -	public CarbonRegistry() {
    +    }
     
    -	}
     
    -    /*
    +    /**
    +     * Add the meta data to governance registry
          *
    +     * @param applicationName Application Name
    +     * @param cartridgeType Cartridge Type
    +     * @param cartridgeMetaData Cartridge Meta Data
    +     * @throws Exception
    +     */
    +    @Override
    +    public void addCartridgeMetaDataDetails(String applicationName, String cartridgeType,
    +                                            CartridgeMetaData cartridgeMetaData) throws
Exception {
    +        log.debug("Adding meta data details");
    --- End diff --
    
    Thanks Ramith for pointing this.As a convention, I think we can check isDebugEnabled.As
there is no String concatenation I guess it didn't check there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message