stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swgkg <...@git.apache.org>
Subject [GitHub] stratos pull request: Meta data service improvement with code refa...
Date Fri, 19 Dec 2014 10:38:16 GMT
Github user swgkg commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/119#discussion_r22098577
  
    --- Diff: components/org.apache.stratos.metadataservice/src/main/java/org/apache/stratos/metadataservice/registry/CarbonRegistry.java
---
    @@ -112,7 +116,7 @@ public boolean deleteApplication(String applicationId) throws RegistryException
             if(StringUtils.isEmpty(applicationId)){
    --- End diff --
    
    Thanks Ramith.
    
    "isBlank" is more suitable here as it is checking String is whitespace, empty ("") or
null.
    This is update with the PR#157


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message