stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rajkumar Rajaratnam <rajkum...@wso2.com>
Subject Re: If floating IP allocation goes wrong, we are not terminating the instances at that point?
Date Wed, 19 Nov 2014 19:05:34 GMT
Even if we didn't add it to the topology, at least we need to terminate the
instance right? But we can't send the member terminated event though.

Thanks.

On Thu, Nov 20, 2014 at 12:18 AM, Nirmal Fernando <nirmal070125@gmail.com>
wrote:

> Yes, if we added it to the topology, then we should send member terminated
> event. (earlier it wasn't the case!)
>
> On Wed, Nov 19, 2014 at 7:41 PM, Rajkumar Rajaratnam <rajkumarr@wso2.com>
> wrote:
>
>> correction //Are you saying that we can't *send* the member terminated
>> event if the member is not in the topology?//
>>
>> On Thu, Nov 20, 2014 at 12:09 AM, Rajkumar Rajaratnam <rajkumarr@wso2.com
>> > wrote:
>>
>>> Yes member is not added to the topology.
>>>
>>> But we have returned the member context to AS ans AS added the member to
>>> pending member list. So if IP allocation goes wrong and if we are not
>>> terminating the instance at this point, it will take another 15 min to spin
>>> up a replacement.
>>>
>>> Are you saying that we can't the member terminated event if the member
>>> is not in the topology? Yes true, but, in some other mail thread, we have
>>> agreed to add the member to the topology as soon as CC get an instance
>>> creation request from AS.
>>>
>>> If we are not going to do this, then we have to avoid terminating the
>>> instance when predefined floating IP allocation goes wrong. Because, when
>>> AS asks to terminate this member after 15 min, that member will not be
>>> there.
>>>
>>> wdyt?
>>>
>>> Thanks.
>>>
>>> On Wed, Nov 19, 2014 at 11:31 PM, Nirmal Fernando <
>>> nirmal070125@gmail.com> wrote:
>>>
>>>> Raj,
>>>>
>>>> At this point have we added the member to the topology? We send the
>>>> member spawned only after a successful IP allocation according to
>>>> https://github.com/apache/stratos/blob/master/components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/impl/CloudControllerServiceImpl.java#L899
>>>>
>>>> On Wed, Nov 19, 2014 at 6:47 PM, Rajkumar Rajaratnam <
>>>> rajkumarr@wso2.com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> So I went through the master branch code and found $Subject.
>>>>>
>>>>>    - If predefined floating IP allocation goes wrong, we are
>>>>>    terminating the instance but not sending member terminated event,
which
>>>>>    will leads to lot of problems :)
>>>>>
>>>>>
>>>>>    - If floating IP allocation goes wrong, we don't even terminate
>>>>>    the instance at that point.
>>>>>
>>>>> I understand that this member will be moved obsolete list and will be
>>>>> eventually terminated after 15 min or so. But if IP allocation goes wrong,
>>>>> we can terminate the member at that point and send member terminated
event
>>>>> right?
>>>>>
>>>>> wdyt?
>>>>>
>>>>> Thanks.
>>>>>
>>>>> --
>>>>> Rajkumar Rajaratnam
>>>>> Committer & PMC Member, Apache Stratos
>>>>> Software Engineer, WSO2
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>> Nirmal
>>>>
>>>> Nirmal Fernando.
>>>> PPMC Member & Committer of Apache Stratos,
>>>> Senior Software Engineer, WSO2 Inc.
>>>>
>>>> Blog: http://nirmalfdo.blogspot.com/
>>>>
>>>
>>>
>>>
>>> --
>>> Rajkumar Rajaratnam
>>> Committer & PMC Member, Apache Stratos
>>> Software Engineer, WSO2
>>>
>>
>>
>>
>> --
>> Rajkumar Rajaratnam
>> Committer & PMC Member, Apache Stratos
>> Software Engineer, WSO2
>>
>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>



-- 
Rajkumar Rajaratnam
Committer & PMC Member, Apache Stratos
Software Engineer, WSO2

Mime
View raw message