stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Udara Liyanage <ud...@wso2.com>
Subject Re: [Grouping] Shall we clean unused code block
Date Thu, 23 Oct 2014 04:36:19 GMT
Hi Martin,

I will have a look and update the thread.

On Thu, Oct 23, 2014 at 12:23 AM, Martin Eppel (meppel) <meppel@cisco.com>
wrote:

>  I still see the exception during startup, opened a JIRA:
>
>
>
> https://issues.apache.org/jira/browse/STRATOS-906
>
>
>
> thanks
>
>
>
> Martin
>
>
>
> *From:* Martin Eppel (meppel)
> *Sent:* Wednesday, October 22, 2014 7:23 AM
> *To:* Isuru Haththotuwa
> *Cc:* Reka Thirunavukkarasu; Udara Liyanage; dev@stratos.apache.org
> *Subject:* RE: [Grouping] Shall we clean unused code block
>
>
>
> +1 - ok
>
>
>
> *From:* isuruh@wso2.com [mailto:isuruh@wso2.com <isuruh@wso2.com>] *On
> Behalf Of *Isuru Haththotuwa
> *Sent:* Wednesday, October 22, 2014 6:48 AM
> *To:* Isuru Haththotuwa
> *Cc:* Martin Eppel (meppel); Reka Thirunavukkarasu; Udara Liyanage;
> dev@stratos.apache.org
> *Subject:* Re: [Grouping] Shall we clean unused code block
>
>
>
> Hi Martin,
>
> This error is fixed now. Please verify.
>
> Also, please don't hesitate to open jiras for such issues with proper
> information since it will help us to properly track the issue.
>
>
>
> On Wed, Oct 22, 2014 at 9:45 AM, Isuru Haththotuwa <isuruh@apache.org>
> wrote:
>
> Hi Martin,
>
> Thank you very much for your effort.
>
>
>
> On Wed, Oct 22, 2014 at 4:46 AM, Martin Eppel (meppel) <meppel@cisco.com>
> wrote:
>
> Hi Reka, Isuru,
>
>
>
> I (gradually) started cleaning up some of the code, quick question /
> comment:
>
>
>
> -        wanted to confirm before removing the following classes / files
> – is it obsolete or do we have further use for
> CompositeApplicationManager.java ?
>
> +1. This is unused AFAIK.
>
> Anyway to be on the safe side, lets check if a particular class is used
> before removing it.
>
>
>
> -        renamed some of the methods for better consistency, e.g.
> org.apache.stratos.rest.endpoint.services.ServiceUtils.deployCompositeApplicationDefintion(CompositeAppDefinition,
> ConfigurationContext, String, String) to ….deployApplicationDefinition()
>
>  +1
>
>
>
> I did a quick sanity test and noticed a few things (I know you sent out an
> email just recently that the branch will be unstable, just want to make
> sure if this is expected):
>
>
>
> + the exception below during startup
>
>
>
> + deploying an application didn’t spawn a VM as expected.
>
>  Thanks for reporting. Will look in to this and fix asap.
>
>
>
> *TID: [0] [STRATOS] [2014-10-21 22:50:49,884] ERROR
> {org.apache.stratos.autoscaler.internal.AutoscalerServerComponent} -  Error
> in activating the autoscaler component
> {org.apache.stratos.autoscaler.internal.AutoscalerServerComponent}*
>
> *java.lang.RuntimeException: Unknown event listener*
>
> *        at
> org.apache.stratos.messaging.message.processor.topology.TopologyMessageProcessorChain.addEventListener(TopologyMessageProcessorChain.java:154)*
>
> *        at
> org.apache.stratos.messaging.message.receiver.topology.TopologyEventMessageDelegator.addEventListener(TopologyEventMessageDelegator.java:48)*
>
> *        at
> org.apache.stratos.messaging.message.receiver.topology.TopologyEventReceiver.addEventListener(TopologyEventReceiver.java:46)*
>
> *        at
> org.apache.stratos.autoscaler.message.receiver.topology.AutoscalerTopologyEventReceiver.addEventListeners(AutoscalerTopologyEventReceiver.java:179)*
>
> *        at
> org.apache.stratos.autoscaler.message.receiver.topology.AutoscalerTopologyEventReceiver.<init>(AutoscalerTopologyEventReceiver.java:60)*
>
> *        at
> org.apache.stratos.autoscaler.internal.AutoscalerServerComponent.activate(AutoscalerServerComponent.java:61)*
>
> *        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)*
>
> *        at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)*
>
> *        at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)*
>
> *        at java.lang.reflect.Method.invoke(Method.java:606)*
>
> *        at
> org.eclipse.equinox.internal.ds.model.ServiceComponent.activate(ServiceComponent.java:260)*
>
> *        at
> org.eclipse.equinox.internal.ds.model.ServiceComponentProp.activate(ServiceComponentProp.java:146)*
>
> *        at
> org.eclipse.equinox.internal.ds.model.ServiceComponentProp.build(ServiceComponentProp.java:347)*
>
> *        at
> org.eclipse.equinox.internal.ds.InstanceProcess.buildComponent(InstanceProcess.java:620)*
>
> *        at
> org.eclipse.equinox.internal.ds.InstanceProcess.buildComponents(InstanceProcess.java:197)*
>
> *        at
> org.eclipse.equinox.internal.ds.Resolver.getEligible(Resolver.java:343)*
>
> *        at
> org.eclipse.equinox.internal.ds.SCRManager.serviceChanged(SCRManager.java:222)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:107)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.BundleContextImpl.dispatchEvent(BundleContextImpl.java:861)*
>
> *        at
> org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)*
>
> *        at
> org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEventPrivileged(ServiceRegistry.java:819)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEvent(ServiceRegistry.java:771)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl.register(ServiceRegistrationImpl.java:130)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.registerService(ServiceRegistry.java:214)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.BundleContextImpl.registerService(BundleContextImpl.java:433)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.BundleContextImpl.registerService(BundleContextImpl.java:451)*
>
> *        at
> org.wso2.carbon.ndatasource.core.internal.DataSourceServiceComponent.registerServices(DataSourceServiceComponent.java:125)*
>
> *        at
> org.wso2.carbon.ndatasource.core.internal.DataSourceServiceComponent.initSuperTenantUserDataSources(DataSourceServiceComponent.java:220)*
>
> *        at
> org.wso2.carbon.ndatasource.core.internal.DataSourceServiceComponent.checkInitTenantUserDataSources(DataSourceServiceComponent.java:205)*
>
> *        at
> org.wso2.carbon.ndatasource.core.internal.DataSourceServiceComponent.setRegistryService(DataSourceServiceComponent.java:156)*
>
> *        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)*
>
> *        at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)*
>
> *        at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)*
>
> *        at java.lang.reflect.Method.invoke(Method.java:606)*
>
> *        at
> org.eclipse.equinox.internal.ds.model.ComponentReference.bind(ComponentReference.java:376)*
>
> *        at
> org.eclipse.equinox.internal.ds.model.ServiceComponentProp.bindReference(ServiceComponentProp.java:432)*
>
> *        at
> org.eclipse.equinox.internal.ds.InstanceProcess.dynamicBind(InstanceProcess.java:416)*
>
> *        at
> org.eclipse.equinox.internal.ds.Resolver.getEligible(Resolver.java:334)*
>
> *        at
> org.eclipse.equinox.internal.ds.SCRManager.serviceChanged(SCRManager.java:222)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:107)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.BundleContextImpl.dispatchEvent(BundleContextImpl.java:861)*
>
> *        at
> org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)*
>
> *        at
> org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEventPrivileged(ServiceRegistry.java:819)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEvent(ServiceRegistry.java:771)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl.register(ServiceRegistrationImpl.java:130)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.registerService(ServiceRegistry.java:214)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.BundleContextImpl.registerService(BundleContextImpl.java:433)*
>
> *        at
> org.wso2.carbon.registry.core.internal.RegistryCoreServiceComponent.activate(RegistryCoreServiceComponent.java:120)*
>
> *        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)*
>
> *        at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)*
>
> *        at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)*
>
> *        at java.lang.reflect.Method.invoke(Method.java:606)*
>
> *        at
> org.eclipse.equinox.internal.ds.model.ServiceComponent.activate(ServiceComponent.java:260)*
>
> *        at
> org.eclipse.equinox.internal.ds.model.ServiceComponentProp.activate(ServiceComponentProp.java:146)*
>
> *        at
> org.eclipse.equinox.internal.ds.model.ServiceComponentProp.build(ServiceComponentProp.java:347)*
>
> *        at
> org.eclipse.equinox.internal.ds.InstanceProcess.buildComponent(InstanceProcess.java:620)*
>
> *        at
> org.eclipse.equinox.internal.ds.InstanceProcess.buildComponents(InstanceProcess.java:197)*
>
> *        at
> org.eclipse.equinox.internal.ds.Resolver.getEligible(Resolver.java:343)*
>
> *        at
> org.eclipse.equinox.internal.ds.SCRManager.serviceChanged(SCRManager.java:222)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:107)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.BundleContextImpl.dispatchEvent(BundleContextImpl.java:861)*
>
> *        at
> org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)*
>
> *        at
> org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEventPrivileged(ServiceRegistry.java:819)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEvent(ServiceRegistry.java:771)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl.register(ServiceRegistrationImpl.java:130)*
>
> *        at
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.registerService(ServiceRegistry.java:214)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.BundleContextImpl.registerService(BundleContextImpl.java:433)*
>
> *        at
> org.wso2.carbon.user.core.internal.Activator.startDeploy(Activator.java:70)*
>
> *        at
> org.wso2.carbon.user.core.internal.BundleCheckActivator.start(BundleCheckActivator.java:61)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.BundleContextImpl$1.run(BundleContextImpl.java:711)*
>
> *        at java.security.AccessController.doPrivileged(Native Method)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.BundleContextImpl.startActivator(BundleContextImpl.java:702)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.BundleContextImpl.start(BundleContextImpl.java:683)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:381)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.AbstractBundle.resume(AbstractBundle.java:390)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.Framework.resumeBundle(Framework.java:1176)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.StartLevelManager.resumeBundles(StartLevelManager.java:559)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.StartLevelManager.resumeBundles(StartLevelManager.java:544)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.StartLevelManager.incFWSL(StartLevelManager.java:457)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.StartLevelManager.doSetStartLevel(StartLevelManager.java:243)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.StartLevelManager.dispatchEvent(StartLevelManager.java:438)*
>
> *        at
> org.eclipse.osgi.framework.internal.core.StartLevelManager.dispatchEvent(StartLevelManager.java:1)*
>
> *        at
> org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)*
>
> *        at
> org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)*
>
> *TID: [0] [STRATOS] [2014-10-21 22:50:49,957]  INFO
> {org.wso2.carbon.event.output.adaptor.mysql.internal.ds.MysqlEventAdaptorServiceDS}
> -  Successfully deployed the output mysql event adaptor service
> {org.wso2.carbon.event.output.adaptor.mysql.internal.ds.MysqlEventAdaptorServiceDS}*
>
>
>
> *From:* Reka Thirunavukkarasu [mailto:reka@wso2.com]
> *Sent:* Sunday, October 19, 2014 9:03 PM
> *To:* Martin Eppel (meppel)
> *Cc:* Udara Liyanage; Isuru Haththotuwa; dev@stratos.apache.org
>
>
> *Subject:* Re: [Grouping] Shall we clean unused code block
>
>
>
> Hi
>
>
>
> On Mon, Oct 20, 2014 at 6:54 AM, Martin Eppel (meppel) <meppel@cisco.com>
> wrote:
>
> If you guys are ok I can start cleaning up this code (since most of it
> comes from the POC anyway), WDYT ?
>
> +1 Martin. We will also clean the code from our end which added by us.
>
>
>
> Thanks,
>
> Reka
>
>
>
> Regards
>
>
>
> Martin
>
>
>
> *From:* Imesh Gunaratne [mailto:imesh@apache.org]
> *Sent:* Friday, October 17, 2014 10:30 PM
> *To:* dev
> *Cc:* Udara Liyanage; Isuru Haththotuwa; Reka Thirunavukkarasu
> *Subject:* Re: [Grouping] Shall we clean unused code block
>
>
>
> +1 Definitely, we need to do this.
>
>
>
> On Fri, Oct 17, 2014 at 9:47 PM, Martin Eppel (meppel) <meppel@cisco.com>
> wrote:
>
> +1
>
>
>
> *From:* Udara Liyanage [mailto:udara@wso2.com]
> *Sent:* Thursday, October 16, 2014 10:26 PM
> *To:* dev
> *Cc:* Isuru Haththotuwa; Reka Thirunavukkarasu; Martin Eppel (meppel)
> *Subject:* [Grouping] Shall we clean unused code block
>
>
>
> Hi,
>
>
>
> There are considerable amount of unused code block. There are places where
> getApplications(), getCompositeApplications() in same class which leads to
> confusion.
>
>
>
> Shall we put some effort to clean up them?
>
>
>
> --
>
>
> Udara Liyanage
>
> Software Engineer
>
> WSO2, Inc.: http://wso2.com
>
> lean. enterprise. middleware
>
> web: http://udaraliyanage.wordpress.com
>
> phone: +94 71 443 6897
>
>
>
>
>
>
> --
>
> Imesh Gunaratne
>
>
>
> Technical Lead, WSO2
>
> Committer & PMC Member, Apache Stratos
>
>
>
>
>
> --
>
> Reka Thirunavukkarasu
> Senior Software Engineer,
> WSO2, Inc.:http://wso2.com,
>
> Mobile: +94776442007
>
> --
>  <%2B94776442007>
>
> Thanks and Regards,
>
> Isuru H.
>  <%2B94776442007>
>
> +94 716 358 048
>
> --
>
>  <%2B94776442007>
>
>
>
>
>
> *Thanks and Regards, Isuru H. <%2B94776442007>*
>
> *+94 716 358 048 <%2B94776442007>*
>
>
>
>


-- 

Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware

web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897

Mime
View raw message