On Mon, Sep 22, 2014 at 4:45 PM, Isuru Perera <email@example.com> wrote:Hi Gayan,
IMHO, the formatting should be done with a different commit.+1Best Regards,The problem is that you have done logic changes along with formatting. I can't figure out what you changed in the code to support MQTT.As a practice, I usually try to keep the diff minimum when doing code changes and do formatting changes in a different commit. I suggest others to do the same. Then we can make sure that the code history is easy to understand.
Just my 2 cents! :)On Mon, Sep 22, 2014 at 4:20 PM, Gayan Gunarathne <firstname.lastname@example.org> wrote:Hi Isuru,Yeah.It is formatted according to the discussion.In the GIT source comparing window it may show white spaces due to this.Is n't?Please find the following code as it is formatted as the discussion.https://github.com/gayangunarathne/stratos/blob/msgtopichierachchy-1/components/org.apache.stratos.cartridge.agent/src/main/java/org/apache/stratos/cartridge/agent/event/publisher/CartridgeAgentEventPublisher.java Coding Standards & Best Practices GuidelinesThanks,GayanOn Mon, Sep 22, 2014 at 3:42 PM, Isuru Perera <email@example.com> wrote:Your PR seems to be messed up due to white space changes :(Did you format classes?--On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <firstname.lastname@example.org> wrote:Hi All,I have changed the Stratos messaging model to support MQTT.Please find the pull request for this.Also I have updated the relevant JIRA(STRATOS-791) as well.Thanks,GayanOn Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <email@example.com> wrote:Hi All,Based on the discussion and our initial research, we are going to use the following client library for the Stratos MQTT based message component.We have done initial research of the functionality of that library with both java and python.Please feel free to share if you have any thoughts on this. Messaging protocol with Stratos python cartridge agentThanks,Gayan
--Best Regards,Gayan GunarathneTechnical LeadWSO2 Inc.--Best Regards,Gayan GunarathneTechnical LeadWSO2 Inc.--Best Regards,Gayan GunarathneTechnical LeadWSO2 Inc.