stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Isuru Perera <isu...@wso2.com>
Subject Re: Pull Requests for Apache Stratos (incubating)
Date Tue, 15 Apr 2014 05:18:22 GMT
Thanks Chris for creating the JIRA.

Also Thanks Nirmal for checking on this! :)

I hope we can accept PRs instead of patches now.


On Tue, Apr 15, 2014 at 9:20 AM, Nirmal Fernando <nirmal070125@gmail.com>wrote:

> Neither me Chris... so probably we don't need a vote :-) Thanks for
> creating the Infra jira.
>
>
> On Tue, Apr 15, 2014 at 9:09 AM, chris snow <chsnow123@gmail.com> wrote:
>
>> I haven't seen anything, I just wasn't sure what the normal process was.
>>
>> Ticket created: https://issues.apache.org/jira/browse/INFRA-7580
>>
>> On Mon, Apr 14, 2014 at 11:02 PM, Nirmal Fernando
>> <nirmal070125@gmail.com> wrote:
>> > I don't think we need a vote... is there a place which say so?
>> >
>> >
>> > On Tue, Apr 15, 2014 at 3:06 AM, chris snow <chsnow123@gmail.com>
>> wrote:
>> >>
>> >> I'm wondering as a starting point if we should get github PRs sent to
>> >> dev@stratos.incubator.apache.org, similar to what was requested for
>> >> cloudstack-docs:
>> >>
>> >> https://issues.apache.org/jira/browse/INFRA-7273
>> >>
>> >> Do we need to vote on this, or shall I go ahead and create a JIRA
>> ticket?
>> >>
>> >> On Mon, Apr 14, 2014 at 10:05 PM, Nirmal Fernando
>> >> <nirmal070125@gmail.com> wrote:
>> >> > Great.. thanks.
>> >> >
>> >> >
>> >> > On Tue, Apr 15, 2014 at 2:34 AM, chris snow <chsnow123@gmail.com>
>> wrote:
>> >> >>
>> >> >> Will do.  I'll post back here when I have some more info.
>> >> >>
>> >> >> On Mon, Apr 14, 2014 at 10:00 PM, Nirmal Fernando
>> >> >> <nirmal070125@gmail.com> wrote:
>> >> >> > Thanks Chris. Would you be able to find some time to follow
that
>> up?
>> >> >> >
>> >> >> >
>> >> >> > On Tue, Apr 15, 2014 at 2:27 AM, chris snow <chsnow123@gmail.com>
>> >> >> > wrote:
>> >> >> >>
>> >> >> >> Hi Nirmal, I've closed the PR on Github.
>> >> >> >>
>> >> >> >> I also found this blog about tigher integration:
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>> >> >> >>
>> >> >> >> On Mon, Apr 14, 2014 at 9:51 PM, Nirmal Fernando
>> >> >> >> <nirmal070125@gmail.com>
>> >> >> >> wrote:
>> >> >> >> > Reviewing and applying a GIT pull request
>> >> >> >> >
>> >> >> >> > Checkout github repository:
>> >> >> >> > https://github.com/apache/incubator-stratos.git
>> >> >> >> >
>> >> >> >> > Add ASF as a remote branch
>> >> >> >> >
>> >> >> >> >     $ git remote add apache
>> >> >> >> > https://git-wip-us.apache.org/repos/asf/incubator-stratos.git
>> >> >> >> >     $ git fetch apache
>> >> >> >> >     $ git checkout -b apache apache/master
>> >> >> >> >
>> >> >> >> > Checking out git pull request eg: pull request number
3 to a
>> new
>> >> >> >> > branch;
>> >> >> >> >
>> >> >> >> >
>> >> >> >> >     $ git fetch origin pull/3/head:pr-3
>> >> >> >> >     $ git checkout pr-3
>> >> >> >> >
>> >> >> >> >
>> >> >> >> > Review the pull request.
>> >> >> >> >
>> >> >> >> > Pushing changes:
>> >> >> >> >
>> >> >> >> >     $ git rebase -i apache
>> >> >> >> >     $ git checkout apache
>> >> >> >> >     $ git merge pr-3
>> >> >> >> >     $ git push apache refs/heads/apache:master
>> >> >> >> >
>> >> >> >> >
>> >> >> >> >
>> >> >> >> >
>> >> >> >> > On Tue, Apr 15, 2014 at 2:11 AM, Nirmal Fernando
>> >> >> >> > <nirmal070125@gmail.com>
>> >> >> >> > wrote:
>> >> >> >> >>
>> >> >> >> >> Can you please check whether you can close the
pull request?
>> >> >> >> >>
>> >> >> >> >>
>> >> >> >> >> On Tue, Apr 15, 2014 at 2:09 AM, Nirmal Fernando
>> >> >> >> >> <nirmal070125@gmail.com>
>> >> >> >> >> wrote:
>> >> >> >> >>>
>> >> >> >> >>> Hi Chris,
>> >> >> >> >>>
>> >> >> >> >>> I think I've successfully merged your pull
request. I'll
>> come up
>> >> >> >> >>> with
>> >> >> >> >>> a
>> >> >> >> >>> set of steps, so that we can add it to a
wiki page.
>> >> >> >> >>>
>> >> >> >> >>>
>> >> >> >> >>> On Tue, Apr 15, 2014 at 12:56 AM, chris snow
>> >> >> >> >>> <chsnow123@gmail.com>
>> >> >> >> >>> wrote:
>> >> >> >> >>>>
>> >> >> >> >>>> Hi Isuru,
>> >> >> >> >>>>
>> >> >> >> >>>> Did you find out what the situation is
regarding Pull
>> Requests?
>> >> >> >> >>>>
>> >> >> >> >>>> I've just added a test PR:
>> >> >> >> >>>> https://github.com/apache/incubator-stratos/pull/3
>> >> >> >> >>>>
>> >> >> >> >>>> Many thanks,
>> >> >> >> >>>>
>> >> >> >> >>>> Chris
>> >> >> >> >>>>
>> >> >> >> >>>>
>> >> >> >> >>>> On Sat, Apr 12, 2014 at 12:41 PM, Isuru
Perera
>> >> >> >> >>>> <isurup@wso2.com>
>> >> >> >> >>>> wrote:
>> >> >> >> >>>> > Hi Devs,
>> >> >> >> >>>> >
>> >> >> >> >>>> > Does anyone know whether we can
accept pull requests.
>> >> >> >> >>>> >
>> >> >> >> >>>> > I know that our repository is mirrored
at GitHub [1].
>> >> >> >> >>>> >
>> >> >> >> >>>> > There is one PR already. I think
we missed that.
>> >> >> >> >>>> >
>> >> >> >> >>>> > I didn't try anything related to
this. Just sending this
>> to
>> >> >> >> >>>> > get
>> >> >> >> >>>> > ideas
>> >> >> >> >>>> > of
>> >> >> >> >>>> > others.
>> >> >> >> >>>> >
>> >> >> >> >>>> > Thanks!
>> >> >> >> >>>> >
>> >> >> >> >>>> > Best Regards,
>> >> >> >> >>>> >
>> >> >> >> >>>> > [1] https://github.com/apache/incubator-stratos
>> >> >> >> >>>> >
>> >> >> >> >>>> > --
>> >> >> >> >>>> > Isuru Perera
>> >> >> >> >>>> > Senior Software Engineer | WSO2,
Inc. | http://wso2.com/
>> >> >> >> >>>> > Lean . Enterprise . Middleware
>> >> >> >> >>>> >
>> >> >> >> >>>> > about.me/chrishantha
>> >> >> >> >>>>
>> >> >> >> >>>>
>> >> >> >> >>>>
>> >> >> >> >>>> --
>> >> >> >> >>>> Check out my professional profile and
connect with me on
>> >> >> >> >>>> LinkedIn.
>> >> >> >> >>>> http://lnkd.in/cw5k69
>> >> >> >> >>>
>> >> >> >> >>>
>> >> >> >> >>>
>> >> >> >> >>>
>> >> >> >> >>> --
>> >> >> >> >>> Best Regards,
>> >> >> >> >>> Nirmal
>> >> >> >> >>>
>> >> >> >> >>> Nirmal Fernando.
>> >> >> >> >>> PPMC Member & Committer of Apache Stratos,
>> >> >> >> >>> Senior Software Engineer, WSO2 Inc.
>> >> >> >> >>>
>> >> >> >> >>> Blog: http://nirmalfdo.blogspot.com/
>> >> >> >> >>
>> >> >> >> >>
>> >> >> >> >>
>> >> >> >> >>
>> >> >> >> >> --
>> >> >> >> >> Best Regards,
>> >> >> >> >> Nirmal
>> >> >> >> >>
>> >> >> >> >> Nirmal Fernando.
>> >> >> >> >> PPMC Member & Committer of Apache Stratos,
>> >> >> >> >> Senior Software Engineer, WSO2 Inc.
>> >> >> >> >>
>> >> >> >> >> Blog: http://nirmalfdo.blogspot.com/
>> >> >> >> >
>> >> >> >> >
>> >> >> >> >
>> >> >> >> >
>> >> >> >> > --
>> >> >> >> > Best Regards,
>> >> >> >> > Nirmal
>> >> >> >> >
>> >> >> >> > Nirmal Fernando.
>> >> >> >> > PPMC Member & Committer of Apache Stratos,
>> >> >> >> > Senior Software Engineer, WSO2 Inc.
>> >> >> >> >
>> >> >> >> > Blog: http://nirmalfdo.blogspot.com/
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >> --
>> >> >> >> Check out my professional profile and connect with me
on
>> LinkedIn.
>> >> >> >> http://lnkd.in/cw5k69
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> > --
>> >> >> > Best Regards,
>> >> >> > Nirmal
>> >> >> >
>> >> >> > Nirmal Fernando.
>> >> >> > PPMC Member & Committer of Apache Stratos,
>> >> >> > Senior Software Engineer, WSO2 Inc.
>> >> >> >
>> >> >> > Blog: http://nirmalfdo.blogspot.com/
>> >> >>
>> >> >>
>> >> >>
>> >> >> --
>> >> >> Check out my professional profile and connect with me on LinkedIn.
>> >> >> http://lnkd.in/cw5k69
>> >> >
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> > Best Regards,
>> >> > Nirmal
>> >> >
>> >> > Nirmal Fernando.
>> >> > PPMC Member & Committer of Apache Stratos,
>> >> > Senior Software Engineer, WSO2 Inc.
>> >> >
>> >> > Blog: http://nirmalfdo.blogspot.com/
>> >>
>> >>
>> >>
>> >> --
>> >> Check out my professional profile and connect with me on LinkedIn.
>> >> http://lnkd.in/cw5k69
>> >
>> >
>> >
>> >
>> > --
>> > Best Regards,
>> > Nirmal
>> >
>> > Nirmal Fernando.
>> > PPMC Member & Committer of Apache Stratos,
>> > Senior Software Engineer, WSO2 Inc.
>> >
>> > Blog: http://nirmalfdo.blogspot.com/
>>
>>
>>
>> --
>> Check out my professional profile and connect with me on LinkedIn.
>> http://lnkd.in/cw5k69
>>
>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>



-- 
Isuru Perera
Senior Software Engineer | WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware

about.me/chrishantha

Mime
View raw message