stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nirmal Fernando <nirmal070...@gmail.com>
Subject Re: [Discuss] Some network related improvements for Stratos
Date Mon, 17 Mar 2014 17:17:10 GMT
Already on it...

Any specific reason for using 1.7.1-stratos-v1 instead of 1.7.1-stratos ?


On Mon, Mar 17, 2014 at 1:13 PM, Jeffrey Nguyen (jeffrngu) <
jeffrngu@cisco.com> wrote:

>  Hi Nirmal,
>
>  Can you and team review the patch and merge it if you don't see any
> issue?   I've tested it on OpenStack and confirmed the new openstack-nova
> module works fine.
>
>  Thanks,
> -Jeffrey
>
>   From: Nirmal Fernando <nirmal070125@gmail.com>
> Reply-To: "dev@stratos.incubator.apache.org" <
> dev@stratos.incubator.apache.org>
> Date: Monday, March 17, 2014 9:07 AM
>
> To: "dev@stratos.incubator.apache.org" <dev@stratos.incubator.apache.org>
> Cc: Imesh Gunaratne <imesh@apache.org>, Lakmal Warusawithana <
> lakmal@wso2.com>, "Vanson Lim (vlim)" <vlim@cisco.com>, "Subbu
> Sundararajan (subbus)" <subbus@cisco.com>, Reka Thirunavukkarasu <
> reka@wso2.com>
> Subject: Re: [Discuss] Some network related improvements for Stratos
>
>   Just noticed that you have attached it :-) Thanks.
>
>
> On Mon, Mar 17, 2014 at 1:05 PM, Nirmal Fernando <nirmal070125@gmail.com>wrote:
>
>>  Hi Jeffrey,
>>
>>  If you have a patch to forking openstack-nova module, do you mind
>> attaching it? I also need to do some fixes in the same module.
>>
>>
>> On Mon, Mar 17, 2014 at 3:02 AM, Nirmal Fernando <nirmal070125@gmail.com>wrote:
>>
>>> Cool!
>>>
>>>
>>> On Mon, Mar 17, 2014 at 2:53 AM, Jeffrey Nguyen (jeffrngu) <
>>> jeffrngu@cisco.com> wrote:
>>>
>>>>
>>>>  Thanks Nirmal for the link to the changes for forked nova module.
>>>> I've created STRATOS-520 for the forking of openstack-nova module.   I'm
>>>> currently testing the forked module.    Will submit PR once it's ready.
>>>>
>>>>  Regards,
>>>> -Jeffrey
>>>>
>>>>   From: Nirmal Fernando <nirmal070125@gmail.com>
>>>> Reply-To: "dev@stratos.incubator.apache.org" <
>>>> dev@stratos.incubator.apache.org>
>>>>  Date: Sunday, March 16, 2014 8:13 AM
>>>> To: "dev@stratos.incubator.apache.org" <
>>>> dev@stratos.incubator.apache.org>
>>>> Cc: Imesh Gunaratne <imesh@apache.org>, Lakmal Warusawithana <
>>>> lakmal@wso2.com>, "Vanson Lim (vlim)" <vlim@cisco.com>, "Subbu
>>>> Sundararajan (subbus)" <subbus@cisco.com>, Reka Thirunavukkarasu <
>>>> reka@wso2.com>
>>>>
>>>> Subject: Re: [Discuss] Some network related improvements for Stratos
>>>>
>>>>
>>>>
>>>>
>>>> On Sun, Mar 16, 2014 at 9:42 PM, Nirmal Fernando <
>>>> nirmal070125@gmail.com> wrote:
>>>>
>>>>> Hi Jeffrey,
>>>>>
>>>>>  On Sun, Mar 16, 2014 at 9:30 PM, Jeffrey Nguyen (jeffrngu) <
>>>>> jeffrngu@cisco.com> wrote:
>>>>>
>>>>>>
>>>>>>  Thanks Imesh and Nirmal for the suggestions.   I'd like to go ahead
>>>>>> and fork jClouds 1.7.1 to pull in JCLOUDS-493.  This will affect
the
>>>>>> openstack nova module.
>>>>>>
>>>>>
>>>>>  Please fork only the openstack-nova module.
>>>>>
>>>>>>
>>>>>>  Can you send me some details on how to proceed with this?
>>>>>>
>>>>>
>>>>>  Please have a look at how vcloud has been forked:
>>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-stratos.git;a=tree;f=dependencies/jclouds;hb=30279d356e91c05d89a18ec246868fe1c664b596
>>>>>
>>>>>
>>>>>>    Do I need to create a separate JIRA and PR for this jClouds fork
>>>>>> or should it be included in the same JIRA for the Stratos enhancement
I'm
>>>>>> working on?
>>>>>>
>>>>>
>>>>>  I think it's better to create a new jira and then from there you can
>>>>> link to your Stratos enhancement related jira as part of the description.
>>>>>
>>>>>>
>>>>>>  Thanks,
>>>>>> -Jeffrey
>>>>>>
>>>>>>   From: Nirmal Fernando <nirmal070125@gmail.com>
>>>>>> Reply-To: "dev@stratos.incubator.apache.org" <
>>>>>> dev@stratos.incubator.apache.org>
>>>>>> Date: Saturday, March 15, 2014 9:08 PM
>>>>>> To: Imesh Gunaratne <imesh@apache.org>
>>>>>> Cc: "dev@stratos.incubator.apache.org" <
>>>>>> dev@stratos.incubator.apache.org>, Lakmal Warusawithana <
>>>>>> lakmal@wso2.com>, "Vanson Lim (vlim)" <vlim@cisco.com>,
"Subbu
>>>>>> Sundararajan (subbus)" <subbus@cisco.com>, Reka Thirunavukkarasu
<
>>>>>> reka@wso2.com>
>>>>>>
>>>>>> Subject: Re: [Discuss] Some network related improvements for Stratos
>>>>>>
>>>>>>   We already have a dependencies folder and Melan has forked vcloud
>>>>>> jclouds provider there.
>>>>>>
>>>>>> @Jeffrey Similarly, you can fork ONLY the necessary jclouds modules
>>>>>> and use the same version used by Stratos' forked vcloud.
>>>>>>
>>>>>>
>>>>>> On Sun, Mar 16, 2014 at 4:47 AM, Imesh Gunaratne <imesh@apache.org>wrote:
>>>>>>
>>>>>>> Hi Jeffrey,
>>>>>>>
>>>>>>>  It's really nice to see your contributions to Stratos.
>>>>>>>
>>>>>>>  Regarding JCLOUDS-493, yes the best option would be to wait
until
>>>>>>> the 1.7.2. However if we need this functionality immediately
may be we
>>>>>>> could fork jclouds including this modification.
>>>>>>>
>>>>>>>  *If we decide to fork jclouds:*
>>>>>>> We could create a folder called "dependencies" in stratos root
>>>>>>> (inside incubator-stratos) and fork jclouds 1.7.1 into it with
a new
>>>>>>> version (something like 1.7.1-stratos-v1). Then we could apply
JCLOUDS-493
>>>>>>> on top of it and update the jclouds dependency versions in Stratos
to
>>>>>>> 1.7.1-stratos-v1.
>>>>>>>
>>>>>>>  Once jclouds releases its next version, 1.7.2 we could remove
this
>>>>>>> fork from Stratos code base.
>>>>>>>
>>>>>>>  Thanks
>>>>>>>
>>>>>>>
>>>>>>> On Sat, Mar 15, 2014 at 3:56 PM, Jeffrey Nguyen (jeffrngu) <
>>>>>>> jeffrngu@cisco.com> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>  Hi,
>>>>>>>>
>>>>>>>>  I'm currently working on the Stratos enhancement to support
>>>>>>>> assignment of fixed private IP addresses and ports to a cartridge
>>>>>>>> (STRATOS-507).   I'm planning to submit a pull request for
this JIRA some
>>>>>>>> time next week.    STRATOS-507 depends on a jClouds enhancement
>>>>>>>> (JCLOUDS-493), which is available on jClouds 1.7.x branch.
  I understand
>>>>>>>> Stratos 4.0.0 Alpha currently using jClouds 1.7.1.
>>>>>>>>
>>>>>>>>  What's the process to get JCLOUDS-493 into Stratos 4.0.0
Alpha?
>>>>>>>> Do we need to wait for the next release of jClouds 1.7.1?
  Without this, I
>>>>>>>> won't be able to submit a pull request for STRATOS-507.
>>>>>>>>
>>>>>>>>  Thanks,
>>>>>>>>
>>>>>>>>  -Jeffrey
>>>>>>>>
>>>>>>>>
>>>>>>>>   From: Lakmal Warusawithana <lakmal@wso2.com>
>>>>>>>> Date: Sunday, March 2, 2014 7:55 PM
>>>>>>>> To: "dev@stratos.incubator.apache.org" <
>>>>>>>> dev@stratos.incubator.apache.org>
>>>>>>>> Cc: Nirmal Fernando <nirmal070125@gmail.com>, "Vanson
Lim (vlim)" <
>>>>>>>> vlim@cisco.com>, jeffrngu <jeffrngu@cisco.com>,
"Subbu
>>>>>>>> Sundararajan (subbus)" <subbus@cisco.com>
>>>>>>>>
>>>>>>>> Subject: Re: [Discuss] Some network related improvements
for
>>>>>>>> Stratos
>>>>>>>>
>>>>>>>>   Hi Martin,
>>>>>>>>
>>>>>>>>  You can create a JIRA [1] for propose improvement/bug fixing.
And
>>>>>>>> when you are ready you can submit a patch (attached patch
to the relevant
>>>>>>>> JIRA). You can find the process of submitting a patch here
[2]. Then
>>>>>>>> commiters will review the patch and applied to relevant repository.
>>>>>>>>
>>>>>>>>  [1]https://issues.apache.org/jira/browse/STRATOS
>>>>>>>> [2]
>>>>>>>> https://cwiki.apache.org/confluence/display/STRATOS/Contributing+as+a+Non-Committer
>>>>>>>>
>>>>>>>>  I hope this will help you guys. Please let us know further
help
>>>>>>>> need.
>>>>>>>>
>>>>>>>> thanks
>>>>>>>>
>>>>>>>> On Mon, Mar 3, 2014 at 8:06 AM, Martin Eppel (meppel) <
>>>>>>>> meppel@cisco.com> wrote:
>>>>>>>>
>>>>>>>>>  Thanks' Nirmal for the pointers -
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> once the code is ready is there a process to get it submitted
and
>>>>>>>>> checked in into the GitHub (review, etc, ...) ?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Martin
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> *From:* Nirmal Fernando [mailto:nirmal070125@gmail.com]
>>>>>>>>> *Sent:* Friday, February 28, 2014 7:46 PM
>>>>>>>>> *To:* Martin Eppel (meppel)
>>>>>>>>> *Cc:* dev@stratos.incubator.apache.org; Vanson Lim (vlim);
>>>>>>>>> Jeffrey Nguyen (jeffrngu); Subbu Sundararajan (subbus)
>>>>>>>>>
>>>>>>>>> *Subject:* Re: [Discuss] Some network related improvements
for
>>>>>>>>> Stratos
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Hi Martin,
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sat, Mar 1, 2014 at 12:26 AM, Martin Eppel (meppel)
<
>>>>>>>>> meppel@cisco.com> wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Hi Nirmal,
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> We'd like to propose an enhancement to the current apache
stratos
>>>>>>>>> cloud controller to allow the assignment of predefined
floating ip when
>>>>>>>>> creating a new instance.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Instead of auto assigning the floating ip address from
the pool (autoAssignIp
>>>>>>>>>  "false" in cartridgeDefinitionBean:iaasProvider, see
example below),
>>>>>>>>> the ip address would be predefined in the cartridge definition
as an
>>>>>>>>> additional property (see example below with property
"floatingIp",
>>>>>>>>> ) and if available in the floating ip pool, assigned
to the instance when
>>>>>>>>> it is created.  If the floating  ip is unavailable, an
exception will be
>>>>>>>>> thrown and the instance will be destroyed.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> As for now it would be sufficient to add this enhancement
for the
>>>>>>>>> OpenStack provider.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Let me know what you think, and since going forward we
would like
>>>>>>>>> to contribute to apache stratos I'd  like to use this
as an opportunity to
>>>>>>>>> get my feet wet and contribute the necessary changes.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Can you please advise on the process and proper steps
to propose
>>>>>>>>> and add an enhancement like this to the project ?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Thanks for the explanation.
>>>>>>>>>
>>>>>>>>> Currently, at line [1], we are calling IaaS's autoAssignIp
method
>>>>>>>>> and ask the IaaS to assign an IP to the instance. Similarly,
I think you
>>>>>>>>> should define a new API operation at [2] and implement
that in each of the
>>>>>>>>> IaaS providers.
>>>>>>>>>
>>>>>>>>> If you look at the OpenstackNovaIaas implementation [3],
you could
>>>>>>>>> see that we call the FloatingIpApi and assign an IP to
an instance. In
>>>>>>>>> order to get the FloatingIpApi please have a look at
line [4]. Now
>>>>>>>>> similarly, if you can just add a new operation which
takes an IP as an
>>>>>>>>> argument and the assign that IP to the instance, that'll
do for you.
>>>>>>>>>
>>>>>>>>> Of course, you need to call this method from [1], once
you've
>>>>>>>>> implemented it. Please make sure that this addition would
not break other
>>>>>>>>> IaaS providers.
>>>>>>>>>
>>>>>>>>> Hope this helps!
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> [1]
>>>>>>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-stratos.git;a=blob;f=components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/impl/CloudControllerServiceImpl.java;h=1d773d0968c9916720c61fee0ca9fa6d9b3f9a52;hb=HEAD#l559
>>>>>>>>>
>>>>>>>>> [2]
>>>>>>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-stratos.git;a=blob;f=components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/interfaces/Iaas.java;h=f45d32e10b0306a9b171ff467bdbaf8668d7035d;hb=HEAD
>>>>>>>>>
>>>>>>>>> [3]
>>>>>>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-stratos.git;a=blob;f=components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/iaases/OpenstackNovaIaas.java;h=d0f50e967fd9de6ed647d4e1f83e3e45e06fdc4e;hb=HEAD#l314
>>>>>>>>>
>>>>>>>>> [4]
>>>>>>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-stratos.git;a=blob;f=components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/iaases/OpenstackNovaIaas.java;h=d0f50e967fd9de6ed647d4e1f83e3e45e06fdc4e;hb=HEAD#l219
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Martin
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Sample Cartridge definition:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ...
>>>>>>>>>
>>>>>>>>> "iaasProvider":
>>>>>>>>>
>>>>>>>>>         [
>>>>>>>>>
>>>>>>>>>             {
>>>>>>>>>
>>>>>>>>>                 "type": "openstack",
>>>>>>>>>
>>>>>>>>>                 "imageId": "RegionOne/${IMAGE_ID}",
>>>>>>>>>
>>>>>>>>>                 "maxInstanceLimit": "4",
>>>>>>>>>
>>>>>>>>>                 "property":
>>>>>>>>>
>>>>>>>>>                 [
>>>>>>>>>
>>>>>>>>>                     {
>>>>>>>>>
>>>>>>>>>                         "name": "instanceType",
>>>>>>>>>
>>>>>>>>>                         "value": "RegionOne/${FLAVOR_ID}"
>>>>>>>>>
>>>>>>>>>                     },
>>>>>>>>>
>>>>>>>>>                     {
>>>>>>>>>
>>>>>>>>>                         "name": "keyPair",
>>>>>>>>>
>>>>>>>>>                         "value": "${KEY}"
>>>>>>>>>
>>>>>>>>>                     },
>>>>>>>>>
>>>>>>>>>                     {
>>>>>>>>>
>>>>>>>>>                         "name": "autoAssignIp",
>>>>>>>>>
>>>>>>>>>                         "value": "false"
>>>>>>>>>
>>>>>>>>>                     },
>>>>>>>>>
>>>>>>>>>                     {
>>>>>>>>>
>>>>>>>>>                         "name": "floatingIp",
>>>>>>>>>
>>>>>>>>>                         "value": "10.10.10.10"
>>>>>>>>>
>>>>>>>>>                     },
>>>>>>>>>
>>>>>>>>>                     {
>>>>>>>>>
>>>>>>>>>                         "name": "securityGroups",
>>>>>>>>>
>>>>>>>>>                         "value": "default"
>>>>>>>>>
>>>>>>>>>                     },
>>>>>>>>>
>>>>>>>>>                     {
>>>>>>>>>
>>>>>>>>>                         "name": "networkInterfaces",
>>>>>>>>>
>>>>>>>>>                         "value": "net1,net2,net3"
>>>>>>>>>
>>>>>>>>>                     }
>>>>>>>>>
>>>>>>>>>                 ]
>>>>>>>>>
>>>>>>>>>             }
>>>>>>>>>
>>>>>>>>>         ],
>>>>>>>>>
>>>>>>>>> ...
>>>>>>>>>
>>>>>>>>> -
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>>
>>>>>>>>> Best Regards,
>>>>>>>>> Nirmal
>>>>>>>>>
>>>>>>>>> Nirmal Fernando.
>>>>>>>>> PPMC Member & Committer of Apache Stratos,
>>>>>>>>> Senior Software Engineer, WSO2 Inc.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Blog: http://nirmalfdo.blogspot.com/
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>  --
>>>>>>>> Lakmal Warusawithana
>>>>>>>> Software Architect; WSO2 Inc.
>>>>>>>> Mobile : +94714289692
>>>>>>>> Blog : http://lakmalsview.blogspot.com/
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>   --
>>>>>>> Imesh Gunaratne
>>>>>>>
>>>>>>> Technical Lead, WSO2
>>>>>>> Committer & PPMC Member, Apache Stratos
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Best Regards,
>>>>>> Nirmal
>>>>>>
>>>>>> Nirmal Fernando.
>>>>>> PPMC Member & Committer of Apache Stratos,
>>>>>> Senior Software Engineer, WSO2 Inc.
>>>>>>
>>>>>>  Blog: http://nirmalfdo.blogspot.com/
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>> Nirmal
>>>>>
>>>>> Nirmal Fernando.
>>>>> PPMC Member & Committer of Apache Stratos,
>>>>> Senior Software Engineer, WSO2 Inc.
>>>>>
>>>>>  Blog: http://nirmalfdo.blogspot.com/
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>> Nirmal
>>>>
>>>> Nirmal Fernando.
>>>> PPMC Member & Committer of Apache Stratos,
>>>> Senior Software Engineer, WSO2 Inc.
>>>>
>>>>  Blog: http://nirmalfdo.blogspot.com/
>>>>
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>> Nirmal
>>>
>>> Nirmal Fernando.
>>> PPMC Member & Committer of Apache Stratos,
>>> Senior Software Engineer, WSO2 Inc.
>>>
>>>  Blog: http://nirmalfdo.blogspot.com/
>>>
>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>>  Blog: http://nirmalfdo.blogspot.com/
>>
>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
>  Blog: http://nirmalfdo.blogspot.com/
>



-- 
Best Regards,
Nirmal

Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.

Blog: http://nirmalfdo.blogspot.com/

Mime
View raw message