Return-Path: X-Original-To: apmail-stratos-dev-archive@minotaur.apache.org Delivered-To: apmail-stratos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C38D71088B for ; Fri, 17 Jan 2014 07:48:05 +0000 (UTC) Received: (qmail 16306 invoked by uid 500); 17 Jan 2014 07:48:04 -0000 Delivered-To: apmail-stratos-dev-archive@stratos.apache.org Received: (qmail 16255 invoked by uid 500); 17 Jan 2014 07:48:03 -0000 Mailing-List: contact dev-help@stratos.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stratos.incubator.apache.org Delivered-To: mailing list dev@stratos.incubator.apache.org Received: (qmail 16242 invoked by uid 99); 17 Jan 2014 07:48:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jan 2014 07:48:02 +0000 X-ASF-Spam-Status: No, hits=2.4 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of damitha23@gmail.com designates 209.85.192.174 as permitted sender) Received: from [209.85.192.174] (HELO mail-pd0-f174.google.com) (209.85.192.174) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jan 2014 07:47:56 +0000 Received: by mail-pd0-f174.google.com with SMTP id w10so3708726pde.33 for ; Thu, 16 Jan 2014 23:47:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=9U21OsVFw+3//3FS+TZTxa2pjFPZ7opQm5kjaXa4PeE=; b=lfQcrUyDsGHicJ9cSTsWDk2QHbvzbgHFZ/Y9Dt7bUO29g+I+fTgrr8v8htK7pgMDvi GWygXRAmdJki6ez4i9gi6wU105GSOcR6/QSiqxZpp+4nYCCUNnox28U457qHm/yFHZAC qYPw5tdLsrKK2KefVo04fBlZ1d+4hasw8buKGILfRIQVAxE7UNWL9oi0AyFUlhG2xw60 FcB7q00/EE4hD5wWeVHRkTUoDGdTiiCl5KVjBXSfG7Tg2zSYzmDoXvyyNVEruCmjvfib CCGs7ULgQ48xhAKn9HaTGQkLyzDivOCAPvKpD+ux122IysQX1VFiBrwRzm+DqtCV03KI MTVQ== MIME-Version: 1.0 X-Received: by 10.66.136.107 with SMTP id pz11mr556509pab.118.1389944854981; Thu, 16 Jan 2014 23:47:34 -0800 (PST) Received: by 10.68.203.193 with HTTP; Thu, 16 Jan 2014 23:47:34 -0800 (PST) In-Reply-To: References: Date: Fri, 17 Jan 2014 13:17:34 +0530 Message-ID: Subject: Re: Uniquely Identifying a LB Cartridge From: damitha kumarage To: dev@stratos.incubator.apache.org Content-Type: multipart/alternative; boundary=001a1133262a56b49904f025c144 X-Virus-Checked: Checked by ClamAV on apache.org --001a1133262a56b49904f025c144 Content-Type: text/plain; charset=ISO-8859-1 Hi Nirmal, IMHO it is not a bad idea to promote an optional property to a mandatory property if it is deemed such promotion is necessary. However such changes desired to be infrequent and can be allowed between major versions. Damitha On Fri, Jan 17, 2014 at 8:49 AM, Nirmal Fernando wrote: > Isuru, > > Problem I see here is, if we follow the same structure, we have to keep > adding new elements to the configuration, which would make it complex to > configure. So, IMO we should keep using properties (since these are > optional elements) leveraging the extensibility of the Cartridge definition > file and correctly document them all. > > > On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa wrote: > >> Hi Devs, >> >> >> Currently it seems that identifying a LB cartridge is done using a >> property in cartridge definition ("name": "load.balancer", "value": >> "true"). The Autoscaler looks at this to decide whether to assign a normal >> Cluster Monitor or a LB Cluster Monitor. If this property is not available, >> there is no way to do this. >> > > Well, the logic should be corrected (if it's not already there) to assume > the value of this property as false by default. So, if you didn't specify > it explicitly, its value still be false. > > >> IMHO, we should not add this as a property, but as a mandatory field. >> WDYT of adding a unique property to identify the LB cartridge? Furthermore, >> we could extend this approach to uniquely identify the four basic cartridge >> categories as previously discussed in the mail thread with subject [1]. >> >> [1]. A Better Model for Generic Types of Cartridges >> >> >> -- >> Thanks and Regards, >> >> Isuru H. >> +94 716 358 048* * >> >> >> > > > -- > Best Regards, > Nirmal > > Nirmal Fernando. > PPMC Member & Committer of Apache Stratos, > Senior Software Engineer, WSO2 Inc. > > Blog: http://nirmalfdo.blogspot.com/ > -- __________________________________________________________________ Damitha Kumarage http://people.apache.org/ __________________________________________________________________ --001a1133262a56b49904f025c144 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi Nirmal,
IMHO it is not a bad idea to= promote an optional property to a mandatory property if it is deemed such = promotion is necessary. However such changes desired to be infrequent and c= an be allowed between major versions.

Damitha


On Fri, Jan 17, 2014 at 8:49 AM, Nirmal Fernando <nirma= l070125@gmail.com> wrote:
Isuru,

Pr= oblem I see here is, if we follow the same structure, we have to keep=A0 ad= ding new elements to the configuration, which would make it complex to conf= igure. So, IMO we should keep using properties (since these are optional el= ements) leveraging the extensibility of the Cartridge definition file and c= orrectly document them all.


On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa = <isuruh@wso2.com> wrote:
Hi Devs,


Currently it seems that identify= ing a LB cartridge is done using a property in cartridge definition ("= name": "load.balancer", "value": "true")= . The Autoscaler looks at this to decide whether to assign a normal=20 Cluster Monitor or a LB Cluster Monitor. If this property is not=20 available, there is no way to do this.

Well, the logic should be corrected (if it's not already= there) to assume the value of this property as false by default. So, if yo= u didn't specify it explicitly, its value still be false.
=A0


--
Best Regards,
Nirmal
<= br>Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Se= nior Software Engineer, WSO2 Inc.




--
_______________________= ___________________________________________
Damitha Kumarage
http://people.apache.org/
___________= _______________________________________________________
--001a1133262a56b49904f025c144--