stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Imesh Gunaratne <im...@apache.org>
Subject Re: git commit: Removed java vendor required property from root pom.xml as it is too restrictive
Date Mon, 11 Nov 2013 18:15:47 GMT
Hi Chris,

Great, appreciate your efforts.
I actually didn't get what you mean by "CI Jobs". Could you please explain
further?

Thanks
Imesh


On Mon, Nov 11, 2013 at 4:59 PM, chris snow <chsnow123@gmail.com> wrote:

> Hi Isuru, Imesh,
>
> I'll do some more investigation into building with OpenJDK.
>
> On another note how can we make sure the build will always work with
> OpenJDK?  One option would be to create two CI jobs - one using OracleJDK
> and one using OpenJDK, but that may be a bit heavy handed?
>
> Many thanks,
>
> Chris
>
>
> On Sun, Nov 10, 2013 at 6:23 PM, Isuru Perera <isurup@wso2.com> wrote:
>
>> Hi Imesh,
>>
>> There are issues when compiling with OpenJDK. Not just Stratos, but when
>> building Carbon as well.
>>
>> I also don't know exact issues, but we should use Oracle JDK 1.6 to
>> compile. I know Chris faced many issues with building Stratos as well as
>> Carbon on OpenJDK.
>>
>> AFAIK, only recommended version for *compiling* is Oracle JDK 1.6.
>>
>> It would be great if we can try and fix issues in other versions.
>>
>> Thanks!
>>
>>
>>  On Sun, Nov 10, 2013 at 10:06 AM, Imesh Gunaratne <imesh@apache.org>wrote:
>>
>>> Hi Chris,
>>>
>>> That would be a good option I guess.
>>> By the way I'm still not clear about the issues we have with Open JDK.
>>> Could you please recall?
>>>
>>> Many Thanks
>>> Imesh
>>>
>>>
>>> On Sun, Nov 10, 2013 at 11:28 PM, chris snow <chsnow123@gmail.com>wrote:
>>>
>>>> Hi Imesh,
>>>>
>>>> How about allowing all JDK vendors EXCEPT for OpenJDK?
>>>>
>>>>                     <rules>
>>>>                         <requireMavenVersion>
>>>>                             <version>[3.0,)</version>
>>>>                         </requireMavenVersion>
>>>>
>>>>                         <requireJavaVersion>
>>>>                             <version>[1.6,1.8)</version>
>>>>                         </requireJavaVersion>
>>>>                          <requireProperty>
>>>>                             <property>java.runtime.name</property>
>>>>                             <message>JAVA_HOME points to OpenJDK which
>>>> is not supported for building Stratos.</message>
>>>>                             <regex>^((?!OpenJDK).)*$</regex>
>>>>                             <regexMessage>JAVA_HOME points to OpenJDK
>>>> which is not supported for building Stratos.</regexMessage>
>>>>                         </requireProperty>
>>>>                     </rules>
>>>>
>>>> It would be good to fail early for OpenJDK if stratos cannot be built
>>>> with OpenJDK.
>>>>
>>>> Many thanks,
>>>>
>>>> Chris
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Sun, Nov 10, 2013 at 5:24 PM, <imesh@apache.org> wrote:
>>>>
>>>>> Updated Branches:
>>>>>   refs/heads/master 1041b1bae -> 973ec4471
>>>>>
>>>>>
>>>>> Removed java vendor required property from root pom.xml as it is too
>>>>> restrictive
>>>>>
>>>>>
>>>>> Project: http://git-wip-us.apache.org/repos/asf/incubator-stratos/repo
>>>>> Commit:
>>>>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/commit/973ec447
>>>>> Tree:
>>>>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/tree/973ec447
>>>>> Diff:
>>>>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/diff/973ec447
>>>>>
>>>>> Branch: refs/heads/master
>>>>> Commit: 973ec4471829c13e420191b13746c8a48cdb5f5e
>>>>> Parents: 1041b1b
>>>>> Author: Imesh Gunaratne <imesh@apache.org>
>>>>> Authored: Sun Nov 10 22:54:05 2013 +0530
>>>>> Committer: Imesh Gunaratne <imesh@apache.org>
>>>>> Committed: Sun Nov 10 22:54:05 2013 +0530
>>>>>
>>>>> ----------------------------------------------------------------------
>>>>>  pom.xml | 12 ------------
>>>>>  1 file changed, 12 deletions(-)
>>>>> ----------------------------------------------------------------------
>>>>>
>>>>>
>>>>>
>>>>> http://git-wip-us.apache.org/repos/asf/incubator-stratos/blob/973ec447/pom.xml
>>>>> ----------------------------------------------------------------------
>>>>> diff --git a/pom.xml b/pom.xml
>>>>> index 1444b26..13b1e6a 100644
>>>>> --- a/pom.xml
>>>>> +++ b/pom.xml
>>>>> @@ -348,18 +348,6 @@
>>>>>                          <requireJavaVersion>
>>>>>                              <version>[1.6,1.8)</version>
>>>>>                          </requireJavaVersion>
>>>>> -                        <requireProperty>
>>>>> -                            <property>java.vendor</property>
>>>>> -                            <message>JAVA_HOME does not point
to a
>>>>> Sun JDK or Oracle JDK.  Only Sun and Oracle JDKs are supported for building
>>>>> Stratos.</message>
>>>>> -                            <regex>(Sun Microsystems Inc\.|Oracle
>>>>> Corporation)</regex>
>>>>> -                            <regexMessage>JAVA_HOME does not point
to
>>>>> a Sun JDK or Oracle JDK.  Only Sun and Oracle JDKs are supported for
>>>>> building Stratos.</regexMessage>
>>>>> -                        </requireProperty>
>>>>> -                        <requireProperty>
>>>>> -                            <property>java.runtime.name</property>
>>>>> -                            <message>JAVA_HOME does not point
to a
>>>>> Sun JDK or Oracle JDK.  Only Sun and Oracle JDKs are supported for building
>>>>> Stratos.</message>
>>>>> -                            <regex>Java\(TM\) SE Runtime
>>>>> Environment</regex>
>>>>> -                            <regexMessage>JAVA_HOME does not point
to
>>>>> a Sun JDK or Oracle JDK.  Only Sun and Oracle JDKs are supported for
>>>>> building Stratos.</regexMessage>
>>>>> -                        </requireProperty>
>>>>>                      </rules>
>>>>>                      <fail>true</fail>
>>>>>                  </configuration>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Check out my professional profile and connect with me on LinkedIn.
>>>> http://lnkd.in/cw5k69
>>>>
>>>
>>>
>>
>>
>> --
>> Isuru Perera
>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>> Lean . Enterprise . Middleware
>>
>> about.me/chrishantha
>>
>
>
>
> --
> Check out my professional profile and connect with me on LinkedIn.
> http://lnkd.in/cw5k69
>

Mime
View raw message