Return-Path: X-Original-To: apmail-stratos-dev-archive@minotaur.apache.org Delivered-To: apmail-stratos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F01FD1099C for ; Sun, 7 Jul 2013 14:18:16 +0000 (UTC) Received: (qmail 5954 invoked by uid 500); 7 Jul 2013 14:18:16 -0000 Delivered-To: apmail-stratos-dev-archive@stratos.apache.org Received: (qmail 5826 invoked by uid 500); 7 Jul 2013 14:18:15 -0000 Mailing-List: contact dev-help@stratos.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stratos.incubator.apache.org Delivered-To: mailing list dev@stratos.incubator.apache.org Received: (qmail 5819 invoked by uid 99); 7 Jul 2013 14:18:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Jul 2013 14:18:14 +0000 X-ASF-Spam-Status: No, hits=1.8 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,T_REMOTE_IMAGE X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of sanjeewa190@gmail.com designates 209.85.217.177 as permitted sender) Received: from [209.85.217.177] (HELO mail-lb0-f177.google.com) (209.85.217.177) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Jul 2013 14:18:08 +0000 Received: by mail-lb0-f177.google.com with SMTP id 10so3020094lbf.8 for ; Sun, 07 Jul 2013 07:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=Cy7CPnwSNMi0AABLiDov0Q7HqYlEte3xayAHpDjb9Rk=; b=FFPpoxD+ZM0jcg7oBrRT6B5GAlwFoJ393Y8r/EQSDRriNZlXqnidHTX5UW40oX9bjF RyqY9dXEHkNxnJgalg9kv8n3RsND6+octTe+oXJMEmbbdlSONYy7PIaPz7iRBlUVpnoK 9Sc44bPF8vBzD0Tx5f0ZZ2d4SfjD7ra5PLBjtaeQnNQxNrUmFuRQVinyEbuzXR79PmRP bDZTx9NUPfDP3Re87EWhAmpztFzPV1vO0LIf9Y2Yrywpk+uYepwruAosShzlmy7YRipt q1dSQCQ+lTdygJmlwp2I4D1BY6Lp7S76FyT08heEWN0+y0GLyj6PpPLHalyzu9F1eWeB jEcg== MIME-Version: 1.0 X-Received: by 10.152.19.40 with SMTP id b8mr8527432lae.34.1373206666966; Sun, 07 Jul 2013 07:17:46 -0700 (PDT) Received: by 10.112.2.134 with HTTP; Sun, 7 Jul 2013 07:17:46 -0700 (PDT) In-Reply-To: References: Date: Sun, 7 Jul 2013 19:47:46 +0530 Message-ID: Subject: Re: We can get rid of following components in Stratos code From: sanjeewa malalgoda To: dev@stratos.incubator.apache.org Content-Type: multipart/alternative; boundary=089e01493b16967f4a04e0ec9779 X-Virus-Checked: Checked by ClamAV on apache.org --089e01493b16967f4a04e0ec9779 Content-Type: text/plain; charset=ISO-8859-1 On Sun, Jul 7, 2013 at 5:44 PM, Shariq Muhammed wrote: > Um even from this list we can cut down, don't need > > 1 - org.wso2.carbon.stratos.landing.page.deployer > 2 - org.wso2.carbon.migration > > Few other too, will talk to Lakmal, AmilaM and finalize it. > > Plus we have to modify some of the components to fit the new requirement. > For example at the moment usage component looks at a stats retriever > provided via a tomcat class, and publish that data to BAM. So the current > usage agent won't be of much use in a PHP cartridge for example. So we need > to make the data retrieved and publisher pluggable ... > +1. If we changed or update usage agent then following components also need to be update. usage service (to retrive usage data). usage ui (visualize usage data). throttling manager /ui (add throttling rules and generate validation information). throttling agent (do throttle). Also we need to add some improvement for tenant-activity component as well. At this moment its working only for carbon based servers. > Guess we need some place to capture the requirements, modifications, > improvements, Jira would be the right place once we have it ... > > > > > On Sun, Jul 7, 2013 at 4:23 PM, sanjeewa malalgoda wrote: > >> Hi All, >> +1 for having minimal set of components. Shall we create list of >> components we need here. AFAIU following components must be there. Please >> add/ remove what i missed here. So we can come up with final list and >> continue refactoring. >> >> autoscaler >> autoscaler-service >> lb-endpoint >> org.wso2.carbon.lb.common >> account-mgt >> org.wso2.carbon.activation >> org.wso2.carbon.stratos.common >> status-monitor >> usage >> artifact-deployment-coordinator >> org.wso2.carbon.cartridge.mgt.ui >> org.wso2.carbon.keystore.mgt >> org.wso2.carbon.stratos.deployment >> tenant-activity >> org.wso2.carbon.stratos.landing.page.deployer >> redirector >> tenant-mgt >> cartridge-agent >> org.wso2.carbon.email.sender >> org.wso2.carbon.migration >> org.wso2.carbon.tenant.dispatcher >> theme-mgt >> domain-validator >> org.wso2.carbon.stratos.cloud.controller >> throttling >> >> >> >> >> On Sun, Jul 7, 2013 at 10:02 AM, Pradeep Fernando wrote: >> >>> Hi Devs, >>> >>> I think we should give priority to identify the minimal set of >>> components. It will help in the refactoring process as well. At the moment >>> I am doing some component refactoring and find it hard to what to re-factor >>> and what not.. >>> >>> thanks, >>> --Pradeep >>> >>> >>> On Sat, Jul 6, 2013 at 9:13 AM, Shariq Muhammed wrote: >>> >>>> On Sat, Jul 6, 2013 at 9:06 AM, Amila Maha Arachchi wrote: >>>> >>>>> >>>>> >>>>> >>>>> On Sat, Jul 6, 2013 at 8:58 AM, Shariq Muhammed wrote: >>>>> >>>>>> If I am not mistaken the following components also could be removed >>>>>> since they are only needed for Carbon based products (cartridges in >>>>>> future ?!) >>>>>> >>>>>> - components/stratos/org.wso2.carbon.ui.menu.stratos - provides a >>>>>> link in the services to direct to CC >>>>>> - components/stratos/org.wso2.carbon.stratos.landing.page.deployer - >>>>>> deploys the carbon service specific landing page webapp >>>>>> >>>>> >>>>> Yes. I'll consider these as well when creating the patch. >>>>> >>>> >>>> Great, guess there is one or two more, need to check the code ... >>>> >>>>> >>>>>> Also how about getting rid of components/*stratos *dir and moving >>>>>> its contents under components/? The reason to the "stratos" dir in >>>>>> carbon code base was to distinguish between stratos and other >>>>>> components, that's not valid here .. >>>>>> >>>>> >>>>> This will be done eventually when the cleanup and re-factoring is >>>>> completed. We are starting from the code which was available in Carbon. >>>>> >>>> >>>> Gotcha ..! >>>> >>>>> >>>>>> >>>>>> >>>>>> >>>>>> On Sat, Jul 6, 2013 at 8:23 AM, Amila Maha Arachchi wrote: >>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> I was going through the incubator code to provide some help on >>>>>>> cleaning it and making it ready for the first release. I have identified >>>>>>> some components which can be deleted from the code. Some of these are not >>>>>>> used anymore and some others are not valid for Apache Stratos. >>>>>>> >>>>>>> components/stratos/org.wso2.carbon.db.keep.alive (unused) >>>>>>> components/stratos/org.wso2.carbon.gapp.registration.ui (not valid) >>>>>>> components/stratos/org.wso2.carbon.google.analytics.ui (not valid) >>>>>>> components/stratos/org.wso2.carbon.migration (unused) >>>>>>> components/stratos/sample-installer (not valid) >>>>>>> >>>>>>> You can simple get rid of the unused ones. For the invalid >>>>>>> components, I will check for dependencies in the >>>>>>> product/stratos2/stratos_controller and provide a patch to remove them. >>>>>>> >>>>>>> There are some other components which will be used as dependencies >>>>>>> from Carbon code. We can get rid of them too. We'll discuss them separately. >>>>>>> >>>>>>> Regards, >>>>>>> Amila. >>>>>>> >>>>>>> -- >>>>>>> *Amila Maharachchi* >>>>>>> Senior Technical Lead >>>>>>> WSO2, Inc.; http://wso2.com >>>>>>> >>>>>>> Blog: http://maharachchi.blogspot.com >>>>>>> Mobile: +94719371446 >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks, >>>>>> Shariq. >>>>>> Phone: +94 777 202 225 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Amila Maharachchi* >>>>> Senior Technical Lead >>>>> WSO2, Inc.; http://wso2.com >>>>> >>>>> Blog: http://maharachchi.blogspot.com >>>>> Mobile: +94719371446 >>>>> >>>>> >>>> >>>> >>>> -- >>>> Thanks, >>>> Shariq. >>>> Phone: +94 777 202 225 >>>> >>> >>> >>> >>> -- >>> Pradeep Fernando. >>> http://pradeepfernando.blogspot.com/ >>> >> >> >> >> -- >> >> *Sanjeewa Malalgoda* >> >> http://sanjeewamalalgoda.blogspot.com/ >> >> >> >> > > > > -- > Thanks, > Shariq. > Phone: +94 777 202 225 > -- *Sanjeewa Malalgoda **B.Sc. Engineering(Hons) Dip. in Com.Sc. AMIESL , MIACSIT, CCNA * Mobile +94713068779 http://sanjeewamalalgoda.blogspot.com/ [image: http://www.stcuthberts.com/Images/Think%20before%20you%20print.gif] --089e01493b16967f4a04e0ec9779 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable



On Sun, Jul 7, 2013 at 5:44 PM, Shariq Muhammed &= lt;shariq@wso2.com= > wrote:
Um even from this list we c= an cut down, don't need

1 -=A0org.wso2.carbon.stratos.landing.page.deployer= =A0
2 -=A0org= .wso2.carbon.migration=A0=A0=A0=A0=A0=A0=A0 =A0 =A0 =A0 = =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0

Few= other too, will talk to Lakmal, AmilaM and finalize it.

Plu= s we have to modify some of the components to fit the new requirement. For = example at the moment usage component looks at a stats retriever provided v= ia a tomcat class, and publish that data to BAM. So the current usage agent= won't be of much use in a PHP cartridge for example. So we need to mak= e the data retrieved and publisher pluggable ...=A0
+1. If we changed or update usage agent then = following components also need to be update.

usage service (to retri= ve usage data).
usage ui (visualize usage data).
throttling manager /ui (add throttling rules and generate validation i= nformation).
throttling agent (do throttle).

Also we need to add some improvement for tenant-activity component as wel= l. At this moment its working only for carbon based servers.


Guess we need some place to capture the requirements, modificat= ions, improvements, Jira would be the right place once we have it ...=A0

=



On Sun, Jul 7, 2013 at 4:23 PM, sanjeewa malalgo= da <sanjeewa190@gmail.com> wrote:
Hi All,
+1 for having minimal set of compone= nts. Shall we create list of components we need here. AFAIU following compo= nents must be there. Please add/ remove what i missed here. So we can come = up with final list and continue refactoring.

autoscaler=A0
autoscaler-service=A0
lb-endpoint=A0
org.wso2= .carbon.lb.common
account-mgt=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0
org.wso2.carbon.activation=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 =A0=A0=A0
org.wso2.carbon.stratos.common=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0
status-monitor=A0
usage
artifact-deployment-coordinator=A0
org.w= so2.carbon.cartridge.mgt.ui=A0=A0=A0=A0=A0
org.wso2.carbon.keystore.mgt= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0
org.wso2.carbon.stratos.deploym= ent=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0=A0
tenant-activity=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0=A0=A0 =A0=A0=A0=A0
org.wso2.carbon.stratos.landing.page.deployer=A0
redirector=A0=A0=A0=A0= =A0=A0=A0
tenant-mgt
cartridge-agent=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0
org.wso2.carbon.email.sender=A0=A0=A0=A0=A0=A0=A0= =A0=A0
org.wso2.carbon.migration=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0
org.wso2.carbon.tenant.dispatcher=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0
theme-mgt
domain-validator=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0
org.wso2.carbon.stratos.cloud.controller=A0 =A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0
throttling




On Sun, Jul 7, 20= 13 at 10:02 AM, Pradeep Fernando <pradeepfn@gmail.com> wro= te:
Hi Devs,

I think we should give priority to identify the minimal set of components.= It will help in the refactoring process as well. At the moment I am doing = some component refactoring and find it hard to what to re-factor and what n= ot..

thanks,
--Pradeep


On Sat, Jul 6, 2013= at 9:13 AM, Shariq Muhammed <shariq@wso2.com> wrote:
On Sat, Jul 6, 2013 at= 9:06 AM, Amila Maha Arachchi <amilam@wso2.com> wrote:



On Sat, Jul 6, 2013 at 8:58 AM,= Shariq Muhammed <shariq@wso2.com> wrote:
If I am not mistaken the fo= llowing components also could be removed since they are only needed for Car= bon based products (cartridges in future ?!)=A0

-=A0= components/stratos/org.wso2.carbon.ui.menu.stratos=A0- provides a link in the services to direct to C= C
-=A0components/stratos/org.wso2.carbon.stratos.landing.page.deployer - deploys the car= bon service specific landing page webapp

Yes. I'll consider these a= s well when creating the patch.

Great, guess there is one or two more, need to chec= k the code ...=A0

Also how a= bout getting rid of components/stratos dir and moving its contents under components/? The reason to the "stratos" dir=A0in carbon code base was to distinguish between stratos and other components, that's not valid here = ..=A0

This will be done eventu= ally when the cleanup and re-factoring is completed. We are starting from t= he code which was available in Carbon.

Gotcha ..!=A0




On Sat, Jul 6, 2013 at 8:23 AM, Amila Maha Arachchi <<= a href=3D"mailto:amilam@wso2.com" target=3D"_blank">amilam@wso2.com>= wrote:
Hi all,

I was going through the incubator code to prov= ide some help on cleaning it and making it ready for the first release. I h= ave identified some components which can be deleted from the code. Some of = these are not used anymore and some others are not valid for Apache Stratos= .

components/stratos/org.wso= 2.carbon.db.keep.= alive (unused)
components/stratos/org.wso2.carbon.gapp.registration.= ui (not valid)
components/stratos/org.wso2.carbon.google.analytics.<= span>ui (not valid)
components/stratos/org.wso2.carbon.migration (unused)
components/stratos/sample-installer (not va= lid)

You can simple get rid of the unused ones. F= or the invalid components, I will check for dependencies in the product/str= atos2/stratos_controller and provide a patch to remove them.

There are some other components which will be used as depend= encies from Carbon code. We can get rid of them too. We'll discuss them= separately.

Regards,
Amila.

--
Amila Maharachchi=
Senior Technical Lead
WSO2, Inc.;=A0http://= wso2.com<= br>
Blog: htt= p://maharachchi.blogspot.com
Mobile: +94719371446




<= font color=3D"#888888">--
Thanks,
Shariq.



--
<= div dir=3D"ltr">Amila Maharachchi
Senior Technical Lead
WSO2, Inc.;=A0http://= wso2.com<= br>
Blog: htt= p://maharachchi.blogspot.com
Mobile: +94719371446




--
Thanks,
Shariq.



<= font color=3D"#888888">--
Pradeep Fernando.
http://pradeepfernando.blogspot.= com/


--



--
Thanks,
Shariq.



--

Sanjeewa Malalgoda
B.Sc. Engineering(Hons)
Dip. in Com.Sc.AMIESL , MIACSIT, CCNA

--089e01493b16967f4a04e0ec9779--