storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] Ethanlm commented on a change in pull request #3265: [STORM-2687] Add network proximity needs based executor sorting method
Date Wed, 27 May 2020 15:02:56 GMT

Ethanlm commented on a change in pull request #3265:
URL: https://github.com/apache/storm/pull/3265#discussion_r431210865



##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -312,6 +312,13 @@
     // the topology.
     public static final String TOPOLOGY_SCHEDULER_STRATEGY = "topology.scheduler.strategy";
 
+    /**
+     * When DefaultResourceAwareStrategy or GenericResourceAwareStrategy is used,
+     * it will arrange unassigned executors based a particular order.
+     * If this config is set to true, the arrangement will be made by network proximity needs.
+     */
+    public static final String TOPOLOGY_RAS_ORDER_EXECUTORS_BY_PROXIMITY_NEEDS = "topology.ras.order.executors.by.proximity.needs";

Review comment:
       Two places in the code set default values for the same config. Maybe we should delete
this to avoid redundancy. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message