storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] kishorvpatil commented on a change in pull request #3211: [STORM-3584] Support getting version info from a wildcard classpath entry
Date Fri, 21 Feb 2020 21:48:01 GMT
kishorvpatil commented on a change in pull request #3211: [STORM-3584] Support getting version
info from a wildcard classpath entry
URL: https://github.com/apache/storm/pull/3211#discussion_r382821322
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/utils/VersionInfo.java
 ##########
 @@ -172,7 +172,10 @@ private static IVersionInfo getFromClasspath(List<String> classpath,
final Strin
                 try {
                     Path parent = p.getParent();
                     List<String> children = new ArrayList<>();
-                    Files.list(parent).forEach(path -> children.add(path.toString()));
+                    Files.list(parent)
+                        //avoid infinite recursion
 
 Review comment:
   Good finding.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message