storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] Ethanlm commented on a change in pull request #3212: [STORM-3587] Allow Scheduler futureTask to gracefully exit with higher timeout.
Date Fri, 21 Feb 2020 21:42:04 GMT
Ethanlm commented on a change in pull request #3212: [STORM-3587] Allow Scheduler futureTask
to gracefully exit with higher timeout.
URL: https://github.com/apache/storm/pull/3212#discussion_r382819032
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
 ##########
 @@ -166,7 +166,7 @@ private void scheduleTopology(TopologyDetails td, Cluster cluster, final
User to
                     Future<SchedulingResult> schedulingFuture = backgroundScheduling.submit(
                         () -> finalRasStrategy.schedule(toSchedule, td));
                     try {
-                        result = schedulingFuture.get(schedulingTimeoutSeconds, TimeUnit.SECONDS);
+                        result = schedulingFuture.get(schedulingTimeoutSeconds + 1, TimeUnit.SECONDS);
 
 Review comment:
   Why do we need ` + 1`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message