storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] krichter722 edited a comment on issue #3020: [STORM-3000] Add missing @Override annotations
Date Sat, 15 Jun 2019 17:46:51 GMT
krichter722 edited a comment on issue #3020: [STORM-3000] Add missing @Override annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502386214
 
 
   #3025 covers some of the issues. Fixing one issue (whitespace, unused variables, etc.)
for all project requires the readjustment of maxAllowedViolations which is painful. I suggest
pushing getting all projects to have maxAllowedViolations == 0. It's the least troublesome
approach in my opinion.
   
   This can be merged, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message