storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] srdo commented on a change in pull request #2911: STORM-2720 : Add TIMESTAMP option for FirstPollOffset for Kafka Trident spout
Date Sun, 12 May 2019 09:53:45 GMT
srdo commented on a change in pull request #2911: STORM-2720 : Add TIMESTAMP option for FirstPollOffset
for Kafka Trident spout
URL: https://github.com/apache/storm/pull/2911#discussion_r283128920
 
 

 ##########
 File path: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/FirstPollOffsetStrategy.java
 ##########
 @@ -31,12 +31,21 @@
      * topology deployment
      */
     LATEST,
+    /**
+     * The kafka spout polls records starting at the earliest offset whose timestamp is greater
than or equal to the given startTimestamp.
 
 Review comment:
   We should mention that these options only work for the Trident spout. I'd like to see this
implemented for the regular spout as well. Are you up for adding support here, or would you
rather leave it for someone else to handle later?
   
   If we don't add support here, we need to mention in this javadoc that it doesn't work for
the regular spout.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message