storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srdo <...@git.apache.org>
Subject [GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies
Date Mon, 04 Jun 2018 19:03:55 GMT
Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2698#discussion_r192818795
  
    --- Diff: storm-client/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java
---
    @@ -54,8 +55,8 @@ public static String exec(String cmd) throws IOException {
             Process process = new ProcessBuilder(new String[]{ "/bin/bash", "-c", cmd }).start();
             try {
                 process.waitFor();
    -            String output = IOUtils.toString(process.getInputStream());
    -            String errorOutput = IOUtils.toString(process.getErrorStream());
    +            String output = IOUtils.toString(process.getInputStream(), Charsets.UTF_8);
    --- End diff --
    
    Won't this break if the system's standard charset isn't UTF-8?


---

Mime
View raw message