storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danny0405 <...@git.apache.org>
Subject [GitHub] storm pull request #2618: [STORM-2905] Fix KeyNotFoundException when kill a ...
Date Tue, 03 Apr 2018 01:28:22 GMT
Github user danny0405 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2618#discussion_r178692521
  
    --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
    @@ -497,7 +497,6 @@ static DynamicState cleanupCurrentContainer(DynamicState dynamicState,
StaticSta
             assert(dynamicState.container.areAllProcessesDead());
             
             dynamicState.container.cleanUp();
    -        staticState.localizer.releaseSlotFor(dynamicState.currentAssignment, staticState.port);
    --- End diff --
    
    yeah, but `staticState.localizer.releaseSlotFor` only remove topology base blobs[jar/code/conf]
which are already taken care of by releaseSlotFor itself.


---

Mime
View raw message