Mailing-List: contact dev-help@storm.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@storm.apache.org
From: srdo <git@git.apache.org>
To: dev@storm.apache.org
Reply-To: dev@storm.apache.org
References: <git-pr-1924-storm@git.apache.org>
In-Reply-To: <git-pr-1924-storm@git.apache.org>
Subject: [GitHub] storm pull request #1924: STORM-2343: New Kafka spout can stop emitting tupl...
Content-Type: text/plain
Message-Id: <20170317161535.83960DFE1E@git1-us-west.apache.org>
Date: Fri, 17 Mar 2017 16:15:35 +0000 (UTC)
archived-at: Fri, 17 Mar 2017 16:15:37 -0000

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1924#discussion_r106687999
  
    --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/builders/SingleTopicKafkaSpoutConfiguration.java ---
    @@ -41,31 +41,22 @@ public static Config getConfig() {
     
         public static StormTopology getTopologyKafkaSpout(int port) {
             final TopologyBuilder tp = new TopologyBuilder();
    -        tp.setSpout("kafka_spout", new KafkaSpout<>(getKafkaSpoutConfig(port)), 1);
    +        tp.setSpout("kafka_spout", new KafkaSpout<>(getKafkaSpoutConfigBuilder(port).build()), 1);
    --- End diff --
    
    The SingleTopicKafkaSpoutConfiguration class was beginning to turn into a mess of telescoping constructors, and it was a bit silly given that we already have a nice builder interface underlying that class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---