storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hmcl <...@git.apache.org>
Subject [GitHub] storm issue #1825: STORM-2236 storm kafka client support manual partition ma...
Date Thu, 15 Dec 2016 05:44:49 GMT
Github user hmcl commented on the issue:

    https://github.com/apache/storm/pull/1825
  
    @liurenjie1024 putting aside for a second the discussion about the need to implement partition
assignment, if we indeed agree that we should support it, I think that the `KafkaSpout` class
is getting a bit too bloated to handle some of these separate requirements. In a sense this
is a new feature on its own. I would favor using a more OOD approach if possible. Perhaps
subclass or compose the `KafkaSpout` @srdo @revans2 what's your opinion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message